getRuleName doesn't work for packages with multiple rules.

[sarvaje]

In these cases, it returns just the name of the package, but not the name of the rule you want to test.

[kshyju]

What is it supposed to return when a package has more than one rules in it ? How does it know what to return ?

[sarvaje]

For example, in the case of rule-typescript-config, getRuleName should return something like:
typescript-config/consistent-casing or typescript-config/import-helpers.

[kshyju]

should return something like:
typescript-config/consistent-casing or typescript-config/import-helpers.

Or ?
Does that mean, any rule present in the package directory ? What is the value of doing that ? What if i want the rule name for a test i am writing for the second/third rule ?

[sarvaje]

Those were just a couple of examples.

What I mean is that getRuleName should return, for multi rules packages, {packageName}/{ruleName}

[kshyju]

Going back to my original question.

What is it supposed to return when a package has more than one rules in it ? How does it know which rule name to return ? The only way to solve the problem is to take the optional rule name when calling the method ?

const ruleName = getRuleName(__dirname,"is-installed");

[sarvaje]

IMO, if we need to pass the rule name, then it is better to hardcode the name.
I think that is the tricky part, how to get the name of the rule given the file path or the folder...

Maybe you can check if getRuleName get a folder or a file, if it is a file, then you get the package name from the directory and the rule name from the fileName.

[molant]

In multi rule packages the convention so far is to name the file test the same as the rule we are testing.

[alrra]

Done in 232564d.