Fix: Some tests

webhintio · Feb 26, 2019 · dccd05e · dccd05e
1 parent 19f6a8e
commit dccd05e
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/packages/hint-no-broken-links/src/hint.ts b/packages/hint-no-broken-links/src/hint.ts
@@ -73,7 +73,7 @@ export default class NoBrokenLinksHint implements IHint {
         };
 
         const isDNSOnlyResourceHint = (element: HTMLElement): boolean => {
-            if (element.nodeName !== 'LINK') {
+            if (element.nodeName.toLowerCase() !== 'link') {
                 return false;
             }
 

diff --git a/packages/hint-no-protocol-relative-urls/tests/tests.ts b/packages/hint-no-protocol-relative-urls/tests/tests.ts
@@ -26,7 +26,7 @@ const tests: HintTest[] = [
         name: `'link' with initial // fails the hint`,
         reports: [{
             message: generateErrorMessage('//site.webmanifest'),
-            position: { column: 37, line: 1 }
+            position: { column: 9, line: 2 }
         }],
         serverConfig: generateHTMLPage('<link rel="manifest" href="//site.webmanifest">')
     },
@@ -46,7 +46,7 @@ const tests: HintTest[] = [
         name: `'script' with initial // fails the hint`,
         reports: [{
             message: generateErrorMessage('//script.js'),
-            position: { column: 23, line: 4 }
+            position: { column: 9, line: 5 }
         }],
         serverConfig: generateHTMLPage(undefined, '<script src="//script.js"></script>')
     },
@@ -66,7 +66,7 @@ const tests: HintTest[] = [
         name: `'a' with initial // fails the hint`,
         reports: [{
             message: generateErrorMessage('//home'),
-            position: { column: 19, line: 4 }
+            position: { column: 9, line: 5 }
         }],
         serverConfig: generateHTMLPage(undefined, '<a href="//home">home</a>')
     },

diff --git a/packages/hint/src/lib/types/html.ts b/packages/hint/src/lib/types/html.ts
@@ -24,6 +24,7 @@ export class HTMLElement {
 
     public constructor(element: ParsedHTMLElement | HTMLElement, ownerDocument?: HTMLDocument) {
         this._element = element instanceof HTMLElement ? element._element : element;
+        this.ownerDocument = ownerDocument;
     }
 
     public get attributes(): INamedNodeMap {