Fix: PR Feedback

webhintio · Mar 7, 2019 · 1158f2e · 1158f2e
1 parent a7da3b2
commit 1158f2e
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/packages/hint/src/lib/utils/dom/get-element-by-url.ts b/packages/hint/src/lib/utils/dom/get-element-by-url.ts
@@ -24,6 +24,7 @@ const getSrcsetUrls = (srcset: string): string[] => {
 };
 
 export default (dom: HTMLDocument, url: string): HTMLElement | null => {
+    // TODO: Cache dom.querySelectorAll?.
     const elements = dom.querySelectorAll('[href],[src],[poster],[srcset]').filter((element: any) => {
         const elementUrl = element.getAttribute('href') || element.getAttribute('src') || element.getAttribute('poster');
         const elementUrls = [elementUrl, ...getSrcsetUrls(element.getAttribute('srcset'))];
@@ -33,6 +34,7 @@ export default (dom: HTMLDocument, url: string): HTMLElement | null => {
         }
 
         const absoluteUrls = elementUrls.map((relativeUrl) => {
+            // TODO: Cache the absolute URL, so we don't run new URL() for the same URL.
             return new URL(relativeUrl, url).href;
         });