Conversation
dlundgren
commented
Oct 7, 2020
- Dropped support for PHP < 7.2
- Also upgraded other dev dependencies
- Dropped support for PHP < 7.2 - Also upgraded other dev dependencies
|
This would most likely constitute a jump to 2.0 of the library, especially considering how I dropped support for PHP < 7.2 |
1 similar comment
|
Wow, good job @dlundgren! I guess I'll need a few days to review and test this. Probably I'll also try to switch to GitHub Actions, since it seems neither Scrutinizer nor Travis actually ran the tests. Regarding a 2.0 major bump – I'd like to avoid that if possible, but I also don't see why this would be necessary? Raising dependency requirements IMHO does not constitute a major change, since users of this library won't need to change code on their side. Probably I'd say it should be a minor release, so we could still ship bugfixes for PHP <7.2 if needed. |
|
You want to be able to use the compatibility layer from here to address Doctrine deprecations. |