Skip to content

Upgraded doctrine/orm to 2.7#30

Merged
mpdude merged 1 commit intowebfactory:masterfrom
dlundgren:upgrade-doctrine-orm
Oct 9, 2020
Merged

Upgraded doctrine/orm to 2.7#30
mpdude merged 1 commit intowebfactory:masterfrom
dlundgren:upgrade-doctrine-orm

Conversation

@dlundgren
Copy link
Contributor

  • Dropped support for PHP < 7.2
  • Also upgraded other dev dependencies

- Dropped support for PHP < 7.2
- Also upgraded other dev dependencies
@dlundgren
Copy link
Contributor Author

This would most likely constitute a jump to 2.0 of the library, especially considering how I dropped support for PHP < 7.2

@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 98.024% when pulling 5435c4a on dlundgren:upgrade-doctrine-orm into 97b166f on webfactory:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.3%) to 98.024% when pulling 5435c4a on dlundgren:upgrade-doctrine-orm into 97b166f on webfactory:master.

@mpdude
Copy link
Member

mpdude commented Oct 8, 2020

Wow, good job @dlundgren!

I guess I'll need a few days to review and test this. Probably I'll also try to switch to GitHub Actions, since it seems neither Scrutinizer nor Travis actually ran the tests.

Regarding a 2.0 major bump – I'd like to avoid that if possible, but I also don't see why this would be necessary? Raising dependency requirements IMHO does not constitute a major change, since users of this library won't need to change code on their side. Probably I'd say it should be a minor release, so we could still ship bugfixes for PHP <7.2 if needed.

@mpdude
Copy link
Member

mpdude commented Oct 9, 2020

Why is it necessary to raise the doctrine/orm requirement to ^2.7?

You want to be able to use the compatibility layer from here to address Doctrine deprecations.

@mpdude mpdude merged commit 18bde98 into webfactory:master Oct 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

Comments