-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(tooling): upgraded webpack packages and included polyfills #225
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look fine. Please reply to all the comments as this will be needed for future reference.
Would be good if you expand on the PR description as well.
"@webex/components": "^1.274.2", | ||
"@webex/sdk-component-adapter": "1.112.6", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for this change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No reason, this change came on it's own somehow
devtool: argv.mode === 'production' ? 'source-map' : 'inline-source-map', | ||
resolve: { | ||
extensions: ['.js', '.jsx'], | ||
fallback: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could we have comments around what these changes are for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, added
hot: true, | ||
port: 9000, | ||
stats: 'errors-warnings', | ||
https: true, | ||
client: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here as well
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
webpack.config.js
Outdated
@@ -82,7 +95,11 @@ module.exports = function(env, argv) { | |||
new webpack.HotModuleReplacementPlugin(), | |||
new webpack.DefinePlugin({ | |||
__appVersion__: JSON.stringify(version) | |||
}) | |||
}), | |||
new webpack.ProvidePlugin({ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
and here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
## [1.26.5](v1.26.4...v1.26.5) (2024-07-24) ### Bug Fixes * **tooling:** upgraded webpack packages and included polyfills ([#225](#225)) ([a5f5482](a5f5482))
🎉 This PR is included in version 1.26.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Putting permanent fix for demo:build issue. Upgraded webpack and included polyfills