feat: expose icecandidateerror event #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbaldino
previously approved these changes
Jun 27, 2024
Agree, created this PR just in case if we wouldn't want to upgrade typescript. |
brycetham
previously approved these changes
Jun 27, 2024
k-wasniowski
force-pushed
the
spark-536950-add-metrics-about-icecandidate-error-codes
branch
from
caf0b80
to
67ecc0d
Compare
brycetham
approved these changes
Jul 10, 2024
k-wasniowski
deleted the
spark-536950-add-metrics-about-icecandidate-error-codes
branch
bbaldino
pushed a commit
that referenced
this pull request
Jul 11, 2024
# [2.10.0](v2.9.0...v2.10.0) (2024-07-11) ### Features * expose icecandidateerror event ([#82](#82)) ([29669bd](29669bd))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPARK-536950
This PR introduces forwarding of IceCandidateError event. We would like to be able to use it in JS-SDK to have a metrics about most common ice gathering issues.
With typescript update to version > 5.0, cast would not be needed.