-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: expose on ice candidate event callback #74
feat: expose on ice candidate event callback #74
Conversation
Not sure if it should expose |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Should we add some simple unit tests for this?
Is this to enable a specific use case/scenario? Don't necessarily disagree with it, but would be good to document the intent in the PR i think |
(I'd agree in general/for completeness it's a good idea though either way) |
@bbaldino This change is added to allow keeping track of generated ICE Candidates. Currently, it will be used to check if Firefox has properly generated relay candidate due to the existing bug -> https://bugzilla.mozilla.org/show_bug.cgi?id=1891503. Should i add this to the PR description? |
@brycetham I would like to, but not sure how such tests should look like. Do you have any proposal for such tests? |
Honestly looking at it again, the only test I'd be interested is on in which it checks if |
# [2.7.0](v2.6.1...v2.7.0) (2024-04-17) ### Features * expose on ice candidate event callback ([#74](#74)) ([c246686](c246686))
This PR exposes an additional event which will allow listening on generated ICE Candidates.
PeerConnection
:IceCandidate
, emits aRTCPeerConnectionIceEvent
with gathered ICE Candidate EventThis change is provided to allow keeping track of generated ICE Candidates. Currently, it will be used to check if Firefox has properly generated relay candidate due to the existing bug -> https://bugzilla.mozilla.org/show_bug.cgi?id=1891503.