fix: check muted property for mute getter #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brycetham
force-pushed
the
btham/fix_mute
branch
from
1ab9048
to
5b7ad18
Compare
bbaldino
previously approved these changes
Jan 18, 2024
|
Holding off on merging this until I make some changes regarding the |
bbaldino
approved these changes
Jan 19, 2024
bbaldino
pushed a commit
that referenced
this pull request
Jan 19, 2024
## [2.3.1](v2.3.0...v2.3.1) (2024-01-19) ### Bug Fixes * check muted property for mute getter ([#69](#69)) ([f07754c](f07754c))
Merged
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also checks the mute property of the track when calling
LocalStream.muted. This more accurately reflects the mute state of the track; for example, when sharing a window, the track gets muted by the browser when the shared window is minimized.