Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(media-helper): update internal-media-core with webrtc-core mute changes #3342

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

brycetham
Copy link
Contributor

COMPLETES WEBEX-368645, WEBEX-364231

This pull request addresses

Updating the internal-media-core version. This includes updates from json-multistream (https://sqbu-github.cisco.com/CPaaS/json-multistream/pull/45) and webrtc-core (webex/webrtc-core#69).

by making the following changes

No changes on the SDK level other than updating package.json and unit tests.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios where tested

Main goal here is to make sure webex/webrtc-core#69 doesn't break mute/unmute functionality in the web client. Manually tested on a locally run web client with the following cases related to mute/unmute:

  1. Web client mutes/unmutes their own microphone/camera.
  2. Host mutes web client's microphone/camera.
  3. Host unmutes web client user's microphone with "moderated unmute mode" enabled.
    • However, this sometimes does not work if "allow attendees to unmute themselves in the meeting" is also disabled. This is an existing bug for the web client. I've filed SPARK-493488 for it.
  4. Web client changes microphone/camera devices while muted/unmuted.
  5. Web client joins a meeting while muted/unmuted.
  6. Web client joins a meeting with "mute on entry" enabled.
  7. Web client mutes/unmutes microphone via device controls (i.e. physical mute button on machine).
    • However, this only changes the mute state in the participant list, not the local mute controls. This is an existing bug for the web client. I've filed SPARK-493485 for it.
  8. Web client user minimizes/unminimizes shared window, which mutes/unmutes share video.
  9. Web client user disconnects/reconnects shared monitor, which mutes/unmutes share video.

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

@brycetham brycetham requested review from a team as code owners January 29, 2024 21:30
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3342.d3m3l2kee0btzx.amplifyapp.com

@arun3528 arun3528 changed the title fix: update internal-media-core with webrtc-core mute changes fix(media-helper): update internal-media-core with webrtc-core mute changes Jan 30, 2024
@arun3528 arun3528 merged commit 6bb2e66 into webex:beta Jan 30, 2024
2 checks passed
mkesavan13 pushed a commit to mkesavan13/webex-js-sdk that referenced this pull request Jan 31, 2024
sreenara pushed a commit that referenced this pull request Jan 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants