fix: sonar fixes (#56)

webex · Jan 20, 2022 · 6e7ce8a · 6e7ce8a
1 parent a1de883
commit 6e7ce8a
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/src/media.spec.ts b/src/media.spec.ts
@@ -70,7 +70,7 @@ describe('ensureDevicePermissions', () => {
       .mockReturnValueOnce(Promise.resolve(createPermissionStatus('granted')));
 
     const testCallbackResponse = 'Test Callback Response';
-    const mockCallback = jest.fn(() => testCallbackResponse);
+    const mockCallback = jest.fn(async () => testCallbackResponse);
 
     const callbackResponse = await media.ensureDevicePermissions(
       [media.DeviceKind.AudioInput, media.DeviceKind.VideoInput],
@@ -97,7 +97,7 @@ describe('ensureDevicePermissions', () => {
 
     await media.ensureDevicePermissions(
       [media.DeviceKind.AudioInput, media.DeviceKind.VideoInput],
-      () => true
+      () => Promise.resolve(true)
     );
 
     expect(mockedNavigatorStub.mediaDevices.enumerateDevices).toHaveBeenCalledTimes(1);
@@ -121,7 +121,7 @@ describe('ensureDevicePermissions2', () => {
 
     await media.ensureDevicePermissions(
       [media.DeviceKind.AudioInput, media.DeviceKind.VideoInput],
-      () => true
+      () => Promise.resolve(true)
     );
 
     expect(mockedNavigatorStub.mediaDevices.getUserMedia.mock.calls).toHaveLength(1);

diff --git a/src/media.ts b/src/media.ts
@@ -114,7 +114,7 @@ async function checkDevicePermissions(deviceKinds: DeviceKind[]): Promise<boolea
  */
 export async function ensureDevicePermissions<T>(
   deviceKinds: DeviceKind[],
-  callback: () => T
+  callback: () => Promise<T>
 ): Promise<T> {
   try {
     const hasDevicePermissions = await checkDevicePermissions(deviceKinds);