Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(internal-plugin-mercury): missing maxRetries property in mercury plugin config #3969

Open
wants to merge 1 commit into
base: next
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions packages/@webex/internal-plugin-mercury/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -55,15 +55,13 @@ webex.init({

### Retries


The default behaviour is for Mercury to continue to try to connect with an exponential back-off. This behavior can be adjusted with the following config params:

- `maxRetries` - the number of times it will retry before error. Default: 0
- `maxRetries` - the number of times it will retry before error. Default: 5
- `initialConnectionMaxRetries` - the number of times it will retry before error on the first connection. Once a connection has been established, any further connection attempts will use `maxRetries`. Default: 0
- `backoffTimeMax` - The maximum time between connection attempts in ms. Default: 32000
- `backoffTimeReset` - The time before the first retry in ms. Default: 1000


## Maintainers

This package is maintained by [Cisco Webex for Developers](https://developer.webex.com/).
Expand Down
6 changes: 6 additions & 0 deletions packages/@webex/internal-plugin-mercury/src/config.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,5 +36,11 @@ export default {
* @type {String}
*/
beforeLogoutOptionsCloseReason: process.env.MERCURY_LOGOUT_REASON || 'done (forced)',

/**
* Maximum number of retries to attempt before giving up
* @type {Number}
*/
maxRetries: process.env.MERCURY_MAX_RETRIES || 5,
},
};
Loading