Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(meetings): incremental log uploads #3899

Draft
wants to merge 1 commit into
base: next
Choose a base branch
from

Conversation

marcin-bazyl
Copy link
Collaborator

This pull request addresses

Some existing issues with logging:

  1. We are often completely missing logs for successful meetings - this is probably because we upload them only on errors and on meeting leave and in successful cases users often just close the tab without clicking leave.
  2. For long running meetings, the sdk buffer gets full and we often have web app logs from the whole meeting but we are missing SDK logs from the beginning of the meeting.
  3. When errors happen and we leave the meeting as a result, we often end up uploading the same log multiple times - all these same copies are stored in the backend.

by making the following changes

Backend allows us to upload logs multiple times for same meeting, so instead of uploading the full log once, let's upload them periodically in smaller chunks - just the diff from the previous successful upload.

Change Type

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation update
  • Tooling change
  • Internal code refactor

The following scenarios were tested

manual run with the web app

I certified that

  • I have read and followed contributing guidelines

  • I discussed changes with code owners prior to submitting this pull request

  • I have not skipped any automated checks

  • All existing and new tests passed

  • I have updated the documentation accordingly


Make sure to have followed the contributing guidelines before submitting.

Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-3899.d3m3l2kee0btzx.amplifyapp.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant