-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new removeLineByKey method as a PoC #20
Open
antsukanova
wants to merge
1
commit into
main
Choose a base branch
from
antsukan/remove-line
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd say this doesn't work very well for the 'other lines' case--do you have any ideas on how that situation would be supported in this scheme?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I think it's important to be able to handle
otherLines
here. If we're going to have this API, I'm wondering if the param for this function should just be aLine
, similar to theaddLine
API? That would allow this API to work with any line (includingotherLines
), not just lines that are associated with a property ofMediaDescription
.Calling this API then, would look something like
mediaDescription.removeLine(mediaDescription.bandwidth)
.This would be tricky for some of the properties though.
mid
andsetup
, for example, are not actual lines, so we'd have to handle those a bit differently.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@bbaldino I've discussed some current code logic with @brycetham, and this example implementation will not be a good idea due to issues with "other lines" as you mentioned. But I want to take time and think about the idea mediaDescription.removeLine(mediaDescription.bandwidth). I also had such an idea, so I just need to see how tricky it is to change some properties' implementations. I will prepare a new example and update this PR. Still, I think aligning functionality to removing likes could be a good idea, and later, it can save us time and keep in our base better abstraction.
@brycetham @bbaldino thanks you for your thoughts and discussion