fix(meeting): fetching captcha details within meeting object #337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shreyas281299
approved these changes
Jun 26, 2024
sreenara
requested changes
Jun 26, 2024
src/MeetingsSDKAdapter.js
Outdated
| }), | ||
| })); | ||
| } else { | ||
| logger.info('MEETING', ID, 'joinMeeting()', 'Password succesfully verified'); |
There was a problem hiding this comment.
There is a typo in the log. Please fix it.
sreenara
approved these changes
Jun 28, 2024
arun3528
pushed a commit
that referenced
this pull request
Jun 28, 2024
## [1.112.5](v1.112.4...v1.112.5) (2024-06-28) ### Bug Fixes * **meeting:** fetching captcha details within meeting object ([#337](#337)) ([34a8a18](34a8a18))
|
🎉 This PR is included in version 1.112.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing the response for verifyPassword() and fetch details like invalidPassword, failureReason and requiredCaptcha and update the meeting object with these details.
Updated verifyPassword() function to accept captcha as a parameter.
Added a new function to refresh the captcha when needed
JIRA: https://jira-eng-gpk2.cisco.com/jira/browse/SPARK-521834
Tests Performed:
Meeting Widget Testing
https://github.com/webex/sdk-component-adapter/assets/65543166/8b6b8ee4-7676-48b2-a122-32a487a7b1d1
Logs
Widgets_Testing_logs.log