fix(MeetingsSdkAdapter): handle joinMeeting with empty password (#340)

webex · Oct 1, 2024 · bf9182e · bf9182e
1 parent 929b753
commit bf9182e
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 0 deletions.
diff --git a/src/MeetingsSDKAdapter.js b/src/MeetingsSDKAdapter.js
@@ -635,6 +635,14 @@ export default class MeetingsSDKAdapter extends MeetingsAdapter {
       const sdkMeeting = this.fetchMeeting(ID);
 
       if (sdkMeeting.passwordStatus === 'REQUIRED') {
+        if (!(options.password || options.hostKey)) {
+          this.updateMeeting(ID, () => (
+            {
+              passwordRequired: true,
+            }));
+
+          return;
+        }
         const res = await sdkMeeting
           .verifyPassword(options.hostKey || options.password, options.captcha);
 

diff --git a/src/MeetingsSDKAdapter.test.js b/src/MeetingsSDKAdapter.test.js
@@ -1196,5 +1196,14 @@ describe('Meetings SDK Adapter', () => {
       expect(mockSDKMeeting.emit.mock.calls[0][0]).toBe('adapter:meeting:updated');
       expect(mockSDKMeeting.emit.mock.calls[0][1]).toMatchObject(mockResponse2);
     });
+
+    it('joinMeeting with empty password', async () => {
+      mockSDKMeeting.verifyPassword = jest.fn();
+      await meetingsSDKAdapter.joinMeeting(meetingID, {password: ''});
+
+      expect(mockSDKMeeting.verifyPassword).not.toHaveBeenCalled();
+      expect(mockSDKMeeting.emit).toHaveBeenCalledTimes(1);
+      expect(mockSDKMeeting.join).not.toHaveBeenCalled();
+    });
   });
 });