Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create workspace #1440

Closed

Conversation

Shreyas281299
Copy link
Contributor

@Shreyas281299 Shreyas281299 commented Oct 14, 2024

Completes -SPARK-559074

My suggestion on how to review this PR - close the packages folder, it only has file name changes. After that its a small PR

This PR is the second PR in the series of many PRs to create react-widgets a yarn workspace
First PR #1438

This PR completes the final 4tasks in the list below

Tasks required to make react-widgets a yarn workspace

  • Move components out of node_modules
  • Adjust the tooling to use the new paths
  • Enable yarn workspace in react-widget
  • Add dependencies inside each package
  • Add scripts for each package
  • Fix tooling to use yarn workspaces packages

Checks

  • Build is passing
  • UTs are passing
  • Integration tests are passing

Testing

  • Ran yarn build:all
  • Ran yarn workspace @webex/ build:src
  • Ran yarn workspace @webex/ serve
  • Served all the demos
  • Ran all UTs

Issues found

All these errors are persistent in master and node-upgrade branch also

  • People list has ENOENT
 error while building - any css file thats why this error - its doesnt affect anything

  • Widget-meet has ENOENT - any css file thats why this error - its doesnt affect anything

  • All demo components fails the buildES function.
  • Issue with tsconfig- webpack build fails for all ts 'widget' components
  • Failling command
- npm run deploy is failing in master and node-upgrade as well
  • We are ignoring all the src files for eslint tests
  • journey tests are failling in the node-upgrade branch as well

'U2C_SERVICE_URL'
]),
new webpack.EnvironmentPlugin({
NODE_ENV: "production",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change is required?

@Shreyas281299 Shreyas281299 reopened this Oct 16, 2024
@Shreyas281299 Shreyas281299 reopened this Oct 16, 2024
@Shreyas281299 Shreyas281299 force-pushed the create-workspace branch 2 times, most recently from 4855808 to 8ddce2c Compare October 22, 2024 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants