Skip to content

Commit

Permalink
feat(adaptive-cards): enable default browser validation of input fields
Browse files Browse the repository at this point in the history
  • Loading branch information
karinasigartau0798 committed Mar 31, 2022
1 parent 0c88533 commit 7c8f2a6
Show file tree
Hide file tree
Showing 11 changed files with 83 additions and 5 deletions.
14 changes: 14 additions & 0 deletions src/components/adaptive-cards/AdaptiveCard/AdaptiveCard.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -170,6 +170,17 @@ export default function AdaptiveCard({
setInputs((prevInputs) => ({...prevInputs, [input.id]: input}));
}, [setInputs]);

const setInputBrowserControlRef = useCallback((id, browserRef) => {
setInputs((prevInputs) => {
const input = prevInputs[id];

return {
...prevInputs,
[id]: {...input, browserRef},
};
});
}, [setInputs]);

const getValue = (id, defval = '') => ((id in inputs && inputs[id].value !== undefined) ? inputs[id].value : defval);

const getAllValues = () => mapValues(inputs, (input) => (input.value));
Expand Down Expand Up @@ -197,6 +208,8 @@ export default function AdaptiveCard({
error = input.errorMessage || `The value you entered must match the pattern ${input.regex}`;
} else if (String(input.value).length > input.maxLength) {
error = `Maximum length is ${input.maxLength}`;
} else if (input.browserRef && !input.browserRef.checkValidity()) {
error = 'The value you entered is invalid.';
}

return {...input, error};
Expand All @@ -220,6 +233,7 @@ export default function AdaptiveCard({
getError,
validate,
submit,
setInputBrowserControlRef,
invalidSubmit,
setElement,
setIsVisible,
Expand Down
10 changes: 9 additions & 1 deletion src/components/adaptive-cards/InputDate/InputDate.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useContext, useEffect} from 'react';
import React, {useContext, useEffect, useState} from 'react';
import PropTypes from 'prop-types';
import webexComponentClasses from '../../helpers';
import {formatDateTime} from '../util';
Expand All @@ -22,9 +22,12 @@ export default function InputDate({data, className, style}) {
setValue,
getValue,
setInput,
setInputBrowserControlRef,
getError,
} = useContext(AdaptiveCardContext);

const [browserControlRef, setBrowserControlRef] = useState(undefined);

useEffect(() => {
setInput({
id: data.id,
Expand All @@ -44,6 +47,10 @@ export default function InputDate({data, className, style}) {
setInput,
]);

useEffect(() => {
setInputBrowserControlRef(data.id, browserControlRef);
}, [browserControlRef, data.id, setInputBrowserControlRef]);

return (
<DateInput
className={cssClasses}
Expand All @@ -54,6 +61,7 @@ export default function InputDate({data, className, style}) {
error={getError(data.id)}
required={data.isRequired}
label={formatDateTime(data.label)}
onBrowserControlRef={(inputRef) => setBrowserControlRef(inputRef)}
onChange={(value) => setValue(data.id, value)}
/>
);
Expand Down
10 changes: 9 additions & 1 deletion src/components/adaptive-cards/InputNumber/InputNumber.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useContext, useEffect} from 'react';
import React, {useContext, useEffect, useState} from 'react';
import PropTypes from 'prop-types';
import webexComponentClasses from '../../helpers';
import AdaptiveCardContext from '../context/adaptive-card-context';
Expand All @@ -22,9 +22,12 @@ export default function InputNumber({data, className, style}) {
setValue,
getValue,
setInput,
setInputBrowserControlRef,
getError,
} = useContext(AdaptiveCardContext);

const [browserControlRef, setBrowserControlRef] = useState(undefined);

useEffect(() => {
setInput({
id: data.id,
Expand All @@ -44,13 +47,18 @@ export default function InputNumber({data, className, style}) {
setInput,
]);

useEffect(() => {
setInputBrowserControlRef(data.id, browserControlRef);
}, [browserControlRef, data.id, setInputBrowserControlRef]);

return (
<NumberInput
className={cssClasses}
error={getError(data.id)}
label={formatDateTime(data.label)}
max={data.max}
min={data.min}
onBrowserControlRef={(inputRef) => setBrowserControlRef(inputRef)}
onChange={(value) => setValue(data.id, value)}
placeholder={data.placeholder}
required={data.isRequired}
Expand Down
9 changes: 8 additions & 1 deletion src/components/adaptive-cards/InputText/InputText.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useContext, useEffect} from 'react';
import React, {useContext, useEffect, useState} from 'react';
import PropTypes from 'prop-types';
import webexComponentClasses from '../../helpers';
import AdaptiveCardContext from '../context/adaptive-card-context';
Expand All @@ -24,11 +24,13 @@ export default function InputText({data, className, style}) {
setValue,
getValue,
setInput,
setInputBrowserControlRef,
getError,
} = useContext(AdaptiveCardContext);
const [cssClasses, sc] = webexComponentClasses('adaptive-cards-input-text', className);
const Input = data.style === 'password' ? PasswordInput : TextInput;
const inlineAction = useAction(data.inlineAction);
const [browserControlRef, setBrowserControlRef] = useState(undefined);

useEffect(() => {
setInput({
Expand All @@ -49,6 +51,10 @@ export default function InputText({data, className, style}) {
setInput,
]);

useEffect(() => {
setInputBrowserControlRef(data.id, browserControlRef);
}, [browserControlRef, data.id, setInputBrowserControlRef]);

return (
<div className={cssClasses} style={style}>
{!data.isMultiline ? (
Expand All @@ -57,6 +63,7 @@ export default function InputText({data, className, style}) {
error={getError(data.id)}
label={formatDateTime(data.label)}
maxLength={data.maxLength}
onBrowserControlRef={(inputRef) => setBrowserControlRef(inputRef)}
onChange={(value) => setValue(data.id, value)}
pattern={data.regex}
placeholder={data.placeholder}
Expand Down
10 changes: 9 additions & 1 deletion src/components/adaptive-cards/InputTime/InputTime.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React, {useContext, useEffect} from 'react';
import React, {useContext, useEffect, useState} from 'react';
import PropTypes from 'prop-types';
import webexComponentClasses from '../../helpers';
import {acPropTypes, registerComponent} from '../Component/Component';
Expand All @@ -22,9 +22,12 @@ export default function InputTime({data, className, style}) {
setValue,
getValue,
setInput,
setInputBrowserControlRef,
getError,
} = useContext(AdaptiveCardContext);

const [browserControlRef, setBrowserControlRef] = useState(undefined);

useEffect(() => {
setInput({
id: data.id,
Expand All @@ -44,6 +47,10 @@ export default function InputTime({data, className, style}) {
setInput,
]);

useEffect(() => {
setInputBrowserControlRef(data.id, browserControlRef);
}, [browserControlRef, data.id, setInputBrowserControlRef]);

return (
<TimeInput
className={cssClasses}
Expand All @@ -54,6 +61,7 @@ export default function InputTime({data, className, style}) {
error={getError(data.id)}
required={data.isRequired}
label={formatDateTime(data.label)}
onBrowserControlRef={(inputRef) => setBrowserControlRef(inputRef)}
onChange={(value) => setValue(data.id, value)}
/>
);
Expand Down
10 changes: 9 additions & 1 deletion src/components/generic/InputField/InputField.jsx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import React from 'react';
import React, {useEffect} from 'react';
import PropTypes from 'prop-types';
import classNames from 'classnames';
import webexComponentClasses from '../../helpers';
Expand All @@ -22,6 +22,7 @@ import Label from '../../inputs/Label/Label';
* @param {number} [props.maxLength] Maximum number of characters allowed
* @param {number} [props.min] Minimum value for the input element
* @param {string} [props.name] Input name
* @param {Function} [props.onBrowserControlRef] Action to perform to take the input ref
* @param {Function} [props.onChange] Action to perform on input change
* @param {string} [props.pattern] Specifies a regular expression that the element's value is checked against
* @param {string} [props.placeholder] Input placeholder
Expand All @@ -47,6 +48,7 @@ export default function InputField({
min,
name,
onChange,
onBrowserControlRef,
pattern,
placeholder,
required,
Expand Down Expand Up @@ -76,6 +78,10 @@ export default function InputField({

useAutoFocus(inputRef, autoFocus);

useEffect(() => {
onBrowserControlRef(inputRef.current);
}, [inputRef, onBrowserControlRef]);

return (
<Label
className={cssClasses}
Expand Down Expand Up @@ -139,6 +145,7 @@ InputField.propTypes = {
min: PropTypes.number,
name: PropTypes.string,
onChange: PropTypes.func,
onBrowserControlRef: PropTypes.func,
pattern: PropTypes.string,
placeholder: PropTypes.string,
required: PropTypes.bool,
Expand Down Expand Up @@ -169,6 +176,7 @@ InputField.defaultProps = {
min: undefined,
name: undefined,
onChange: undefined,
onBrowserControlRef: () => {},
pattern: undefined,
placeholder: undefined,
required: false,
Expand Down
5 changes: 5 additions & 0 deletions src/components/inputs/DateInput/DateInput.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ import {InputField} from '../../generic';
* @param {boolean} [props.required=false] Flag indicating input required
* @param {string} [props.error] Error text
* @param {string} [props.label] Label text
* @param {Function} [props.onBrowserControlRef] Action to perform to take the input ref
* @param {Function} props.onChange Action to perform on input change
* @returns {object} JSX of the component
*/
Expand All @@ -27,6 +28,7 @@ export default function DateInput({
required,
error,
label,
onBrowserControlRef,
onChange,
}) {
const [cssClasses] = webexComponentClasses('date-input', className);
Expand All @@ -41,6 +43,7 @@ export default function DateInput({
required={required}
error={error}
onChange={onChange}
onBrowserControlRef={onBrowserControlRef}
value={value}
label={label}
/>
Expand All @@ -56,6 +59,7 @@ DateInput.propTypes = {
required: PropTypes.bool,
error: PropTypes.string,
label: PropTypes.string,
onBrowserControlRef: PropTypes.func,
onChange: PropTypes.func.isRequired,
};

Expand All @@ -68,4 +72,5 @@ DateInput.defaultProps = {
required: false,
error: undefined,
label: undefined,
onBrowserControlRef: undefined,
};
5 changes: 5 additions & 0 deletions src/components/inputs/NumberInput/NumberInput.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,7 @@ const HINTS = {
* @param {number} [props.max] Maximum value for the input element
* @param {number} [props.min] Minimum value for the input element
* @param {string} [props.name] Input name
* @param {Function} [props.onBrowserControlRef] Action to perform to take the input ref
* @param {Function} props.onChange Action to perform on input change
* @param {string} [props.placeholder] Input placeholder
* @param {boolean} [props.required=false] Flag indicating input required
Expand All @@ -41,6 +42,7 @@ export default function NumberInput({
max,
min,
name,
onBrowserControlRef,
onChange,
placeholder,
required,
Expand Down Expand Up @@ -92,6 +94,7 @@ export default function NumberInput({
min={min}
max={max}
name={name}
onBrowserControlRef={onBrowserControlRef}
onChange={onChange}
placeholder={placeholder}
required={required}
Expand All @@ -114,6 +117,7 @@ NumberInput.propTypes = {
max: PropTypes.number,
min: PropTypes.number,
name: PropTypes.string,
onBrowserControlRef: PropTypes.func,
onChange: PropTypes.func.isRequired,
placeholder: PropTypes.string,
required: PropTypes.bool,
Expand All @@ -134,6 +138,7 @@ NumberInput.defaultProps = {
max: undefined,
min: undefined,
name: undefined,
onBrowserControlRef: undefined,
placeholder: undefined,
required: false,
style: undefined,
Expand Down
5 changes: 5 additions & 0 deletions src/components/inputs/PasswordInput/PasswordInput.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ const HINTS = {
* @param {string} [props.label] Label text
* @param {number} [props.maxLength] Maximum number of characters allowed
* @param {string} [props.name] Input name
* @param {Function} [props.onBrowserControlRef] Action to perform to take the input ref
* @param {Function} props.onChange Action to perform on input change
* @param {string} [props.pattern] Specifies a regular expression that the element's value is checked against
* @param {string} [props.placeholder] Input placeholder
Expand All @@ -36,6 +37,7 @@ export default function PasswordInput({
label,
maxLength,
name,
onBrowserControlRef,
onChange,
pattern,
placeholder,
Expand Down Expand Up @@ -71,6 +73,7 @@ export default function PasswordInput({
label={label}
maxLength={maxLength}
name={name}
onBrowserControlRef={onBrowserControlRef}
onChange={onChange}
pattern={pattern}
placeholder={placeholder}
Expand All @@ -92,6 +95,7 @@ PasswordInput.propTypes = {
label: PropTypes.string,
maxLength: PropTypes.number,
name: PropTypes.string,
onBrowserControlRef: PropTypes.func,
onChange: PropTypes.func.isRequired,
pattern: PropTypes.string,
placeholder: PropTypes.string,
Expand All @@ -109,6 +113,7 @@ PasswordInput.defaultProps = {
label: undefined,
maxLength: undefined,
name: undefined,
onBrowserControlRef: undefined,
pattern: undefined,
placeholder: undefined,
required: false,
Expand Down
5 changes: 5 additions & 0 deletions src/components/inputs/TextInput/TextInput.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ const HINTS = {
* @param {string} [props.label] Label text
* @param {number} [props.maxLength] Maximum number of characters allowed
* @param {string} [props.name] Input name
* @param {Function} [props.onBrowserControlRef] Action to perform to take the input ref
* @param {Function} props.onChange Action to perform on input change
* @param {string} [props.pattern] Specifies a regular expression that the element's value is checked against
* @param {string} [props.placeholder] Input placeholder
Expand All @@ -37,6 +38,7 @@ export default function TextInput({
maxLength,
name,
onChange,
onBrowserControlRef,
pattern,
placeholder,
required,
Expand Down Expand Up @@ -64,6 +66,7 @@ export default function TextInput({
maxLength={maxLength}
name={name}
onChange={onChange}
onBrowserControlRef={onBrowserControlRef}
pattern={pattern}
placeholder={placeholder}
required={required}
Expand Down Expand Up @@ -92,6 +95,7 @@ TextInput.propTypes = {
tabIndex: PropTypes.number,
type: PropTypes.string,
value: PropTypes.string,
onBrowserControlRef: PropTypes.func,
};

TextInput.defaultProps = {
Expand All @@ -109,4 +113,5 @@ TextInput.defaultProps = {
tabIndex: 0,
type: 'text',
value: undefined,
onBrowserControlRef: undefined,
};
Loading

0 comments on commit 7c8f2a6

Please sign in to comment.