Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

onlyDriver feature #848

Merged
merged 6 commits into from
Oct 2, 2023
Merged

onlyDriver feature #848

merged 6 commits into from
Oct 2, 2023

Conversation

udarrr
Copy link
Member

@udarrr udarrr commented Oct 1, 2023

Hi @christian-bromann here is new feature onlyDriver it allow to install or start any driver directly without selenium-server (prevented from downloading also)

Ports for drivers by default:
for chromedirver port is 9515
for edgedriver port is 9515
for firefox port is 4444

The ports can be changed in onlyDriverArgs

Before each driver execution process killer check port and process name existence

related to #843

Copy link
Member

@christian-bromann christian-bromann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@udarrr
Copy link
Member Author

udarrr commented Oct 2, 2023

@christian-bromann Could you merge it like 9.2.0 ?

@christian-bromann
Copy link
Member

@udarrr I just added you to the project org, can you check whether you can merge and release now? Let me know if you have any questions.

@udarrr
Copy link
Member Author

udarrr commented Oct 2, 2023

@udarrr I just added you to the project org, can you check whether you can merge and release now? Let me know if you have any questions.

Oh. Looks like not, it's still not allowed me. If you don't mind could you merge it by you own now, because i'd like to use the changes asap...and then we could check all the permissions.

@christian-bromann
Copy link
Member

Sure. Make sure to check your emails and accept the invitation.

@christian-bromann christian-bromann merged commit 1822711 into webdriverio:main Oct 2, 2023
8 checks passed
@udarrr
Copy link
Member Author

udarrr commented Oct 2, 2023

Sure. Make sure to check your emails and accept the invitation.

Oh That's what it was... yes there is a invitation thank you @christian-bromann I do my best! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants