Skip to content
This repository has been archived by the owner on Sep 20, 2019. It is now read-only.

Fix Promise.prototype.catch closure issue #844

Merged
merged 1 commit into from
Sep 11, 2017
Merged

Fix Promise.prototype.catch closure issue #844

merged 1 commit into from
Sep 11, 2017

Conversation

dfreedm
Copy link
Contributor

@dfreedm dfreedm commented Sep 11, 2017

Manually import ES6Promise polyfill and closure export catch function
Fixes #837

Manually import ES6Promise polyfill and closure export `catch` function
Fixes #837
*/
if (!window.Promise) {
window.Promise = ES6Promise;
ES6Promise.prototype['catch'] = ES6Promise.prototype.catch;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:bleeding_eyes:

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sweet summer child...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

popcorn.gif

@dfreedm dfreedm merged commit 8782120 into master Sep 11, 2017
@dfreedm dfreedm deleted the fix-promise branch September 11, 2017 19:37
@dfreedm dfreedm mentioned this pull request Sep 12, 2017
@ghost
Copy link

ghost commented Sep 12, 2017

I know it's a stupid question, but how to get this fix in my local application, please?

@keanulee
Copy link
Contributor

You can update bower.json dependencies to include "webcomponentsjs": "master" or wait until a new release is published.

@azakus good time to tag a new release?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants