Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ShadyDOM]: <slot>.insertBefore causes an exception #266

Closed
sorvell opened this issue Feb 10, 2020 · 0 comments · Fixed by #267
Closed

[ShadyDOM]: <slot>.insertBefore causes an exception #266

sorvell opened this issue Feb 10, 2020 · 0 comments · Fixed by #267
Assignees
@sorvell
Labels
Severity: High Type: Bug

Comments

@sorvell
Copy link
Collaborator

sorvell commented Feb 10, 2020

If fallback content is added via insertBefore after a shadowRoot has rendered, an exception occurs. This is because this is not currently detected as a rendering scenario that requires a shadowRoot to perform distribution. Instead a native insertion is attempted and fails because the ref_node is not actually a composed child of the element.
@sorvell sorvell self-assigned this Feb 10, 2020
sorvell pushed a commit that referenced this issue Feb 10, 2020
Correctly detect slot.insertBefore as requiring shadowRoot distribu…
e5673be 
…tion

Fixes #266. If a `<slot>` is in a shadowRoot, when its children change, the shadowRoot needs to distribute to correctly render.
@sorvell sorvell mentioned this issue Feb 10, 2020
Merged
@benoitjchevalier benoitjchevalier mentioned this issue Sep 23, 2020
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sorvell sorvell

Labels
Severity: High Type: Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly detect slot.insertBefore as requiring shadowRoot distribution webcomponents/polyfills
1 participant
@sorvell