Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 1.21.1 support #4143

Merged
merged 2 commits into from
Aug 16, 2024
Merged

Add 1.21.1 support #4143

merged 2 commits into from
Aug 16, 2024

Conversation

forkiesassds
Copy link
Contributor

@forkiesassds forkiesassds commented Aug 10, 2024

Closes #4141
Closes #4144

Copy link

@evanpacini evanpacini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't work. Need to update the bukkit/spigot version first.

EDIT: I was stupid, forget what I said, my dumbass somehow expected API-breaking changes from a minor version change.

@forkiesassds
Copy link
Contributor Author

Won't work. Need to update the bukkit/spigot version first.

Dynmap reports (MC: 1.21) on 1.21 and (MC: 1.21.1) on 1.21.1. As it checks for (MC: 1.21 it should work with both 1.21 and 1.21.1

@Aliebc
Copy link

Aliebc commented Aug 13, 2024

@forkiesassds Your patch works for me. Thanks!

@ChubbyWubbby
Copy link

I am struggling to find the helper.json. I am running a paper server so I am not sure if it is laid out differently? I tried looking for it with the same filepath and I can't seem to locate it.

@forkiesassds
Copy link
Contributor Author

I am struggling to find the helper.json. I am running a paper server so I am not sure if it is laid out differently? I tried looking for it with the same filepath and I can't seem to locate it.

It's a problem within built binaries itself, not a configuration problem. You can try manually using a bytecode editor to edit the string used for checking version number.

@Axtazer Axtazer mentioned this pull request Aug 15, 2024
@mikeprimm mikeprimm merged commit a4483ef into webbukkit:v3.0 Aug 16, 2024
@mikeprimm
Copy link
Member

Looks good - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pls update for 1.21.1 Plugin crash after startup server
7 participants