Fixed topo offsets #4100
Closed
Fixed topo offsets #4100
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
February 6, 2024 18:58
minimusubi
reviewed
Apr 9, 2024
There was a problem hiding this comment.
just a few thoughts:
- looks like your changes for #4064 are here too. however, this wont matter if 4064 is merged first
- this change assumes all 1.17+ worlds are 363 height- the end and nether are not. though i don't think it will error, it might be cleaner to avoid reading the extra color values
- this also wont work for any worlds with larger custom heights (achievable through data packs or mods)
- if it works the way I assume it does, it may be better to programmatically read the height values instead of using magic numbers (for example, from
MapIterator.getWorldHeight()andMapIterator.getWorldYMin()). this also future-proofs the code for any future world height changes
- if it works the way I assume it does, it may be better to programmatically read the height values instead of using magic numbers (for example, from
| fillcolor = new Color[worldheight]; /* Color by Y, must be range of total world height, offset by +64*/ | ||
| /* Load defined colors from parameters */ | ||
| for(int i = 0; i < worldheight; i++) { | ||
| fillcolor[i] = configuration.getColor("color" + (i - 64), null); /* need to substract by 64 because Color does not accept <0 indexes*/ |
There was a problem hiding this comment.
this wont work as expected on nether and end worlds, which do not have an expanded height (0-255)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.