Skip to content

Commit

Permalink
Merge pull request #4 from webaverse/fix-first-use
Browse files Browse the repository at this point in the history
Fix onFirstUse this binding
  • Loading branch information
Avaer Kazmer authored Jan 29, 2022
2 parents 76c93b3 + b791a83 commit bd630fb
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 21 deletions.
32 changes: 16 additions & 16 deletions build/three.js
Original file line number Diff line number Diff line change
Expand Up @@ -14111,7 +14111,7 @@
this.getUniforms = function () {
if (cachedUniforms === undefined) {
// Populates cachedUniforms and cachedAttributes
onFirstUse();
onFirstUse.call(this);
}

return cachedUniforms;
Expand All @@ -14123,7 +14123,7 @@
this.getAttributes = function () {
if (cachedAttributes === undefined) {
// Populates cachedAttributes and cachedUniforms
onFirstUse();
onFirstUse.call(this);
}

return cachedAttributes;
Expand Down Expand Up @@ -34150,15 +34150,15 @@
// TODO: delete this comment?
const distanceGeometry = new THREE.IcosahedronBufferGeometry( 1, 2 );
const distanceMaterial = new THREE.MeshBasicMaterial( { color: hexColor, fog: false, wireframe: true, opacity: 0.1, transparent: true } );
this.lightSphere = new THREE.Mesh( bulbGeometry, bulbMaterial );
this.lightSphere = new THREE.Mesh( bulbGeometry, bulbMaterial );
this.lightDistance = new THREE.Mesh( distanceGeometry, distanceMaterial );
const d = light.distance;
if ( d === 0.0 ) {
this.lightDistance.visible = false;
} else {
this.lightDistance.scale.set( d, d, d );
}
this.add( this.lightDistance );
const d = light.distance;
if ( d === 0.0 ) {
this.lightDistance.visible = false;
} else {
this.lightDistance.scale.set( d, d, d );
}
this.add( this.lightDistance );
*/
}

Expand All @@ -34175,12 +34175,12 @@
}
/*
const d = this.light.distance;
if ( d === 0.0 ) {
this.lightDistance.visible = false;
} else {
this.lightDistance.visible = true;
if ( d === 0.0 ) {
this.lightDistance.visible = false;
} else {
this.lightDistance.visible = true;
this.lightDistance.scale.set( d, d, d );
}
}
*/

}
Expand Down Expand Up @@ -34579,7 +34579,7 @@
1/___0/|
| 6__|_7
2/___3/
0: max.x, max.y, max.z
0: max.x, max.y, max.z
1: min.x, max.y, max.z
2: min.x, min.y, max.z
3: max.x, min.y, max.z
Expand Down
2 changes: 1 addition & 1 deletion build/three.min.js

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions build/three.module.js
Original file line number Diff line number Diff line change
Expand Up @@ -18695,7 +18695,7 @@ function WebGLProgram( renderer, cacheKey, parameters, bindingStates ) {
if ( cachedUniforms === undefined ) {

// Populates cachedUniforms and cachedAttributes
onFirstUse();
onFirstUse.call(this);

}

Expand All @@ -18712,7 +18712,7 @@ function WebGLProgram( renderer, cacheKey, parameters, bindingStates ) {
if ( cachedAttributes === undefined ) {

// Populates cachedAttributes and cachedUniforms
onFirstUse();
onFirstUse.call(this);

}

Expand Down
4 changes: 2 additions & 2 deletions src/renderers/webgl/WebGLProgram.js
Original file line number Diff line number Diff line change
Expand Up @@ -839,7 +839,7 @@ function WebGLProgram( renderer, cacheKey, parameters, bindingStates ) {
if ( cachedUniforms === undefined ) {

// Populates cachedUniforms and cachedAttributes
onFirstUse();
onFirstUse.call(this);

}

Expand All @@ -856,7 +856,7 @@ function WebGLProgram( renderer, cacheKey, parameters, bindingStates ) {
if ( cachedAttributes === undefined ) {

// Populates cachedAttributes and cachedUniforms
onFirstUse();
onFirstUse.call(this);

}

Expand Down

0 comments on commit bd630fb

Please sign in to comment.