refact: Removed the Hash struct to_plain_str function.
#723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
…d it with a standard `to_string` func. Signed-off-by: Han Xiaoyang <[email protected]>
genedna
approved these changes
Dec 9, 2024
Merged
via the queue into
web3infra-foundation:main
with commit Dec 9, 2024
21c42b3
10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactoring: Removed the
Hashstruct:: to_plain_strfunction and replaced it with a standard to_string.Now if you want to convert a hash to a string, you can call
to_stringinstead of the previousto_plain_str. As an alternative, I've addedto_color_strfunctions that can simply beautify the output of the hash value. This PR solves the previous API design flaw, which may bring the risk of error in string conversion.