-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(onNewProviderDiscovered): callback-parameter #7242
Conversation
Callback for `onNewProviderDiscovered`should have `EIP6963ProvidersMapUpdateEvent` parameter Closes #7241
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller
Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: c177665 | Previous: 2f24244 | Ratio |
---|---|---|---|
processingTx |
21833 ops/sec (±7.86% ) |
23756 ops/sec (±7.52% ) |
1.09 |
processingContractDeploy |
36691 ops/sec (±10.24% ) |
40022 ops/sec (±7.39% ) |
1.09 |
processingContractMethodSend |
14680 ops/sec (±10.24% ) |
16888 ops/sec (±7.21% ) |
1.15 |
processingContractMethodCall |
25209 ops/sec (±9.54% ) |
27258 ops/sec (±8.42% ) |
1.08 |
abiEncode |
42100 ops/sec (±5.71% ) |
44502 ops/sec (±6.85% ) |
1.06 |
abiDecode |
28208 ops/sec (±10.91% ) |
31804 ops/sec (±6.33% ) |
1.13 |
sign |
1491 ops/sec (±3.98% ) |
1546 ops/sec (±4.08% ) |
1.04 |
verify |
363 ops/sec (±0.60% ) |
372 ops/sec (±0.57% ) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7242 +/- ##
=======================================
Coverage 94.48% 94.48%
=======================================
Files 216 216
Lines 8439 8439
Branches 2318 2318
=======================================
Hits 7974 7974
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
Callback for
onNewProviderDiscovered
should haveEIP6963ProvidersMapUpdateEvent
parameterCloses #7241