Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(onNewProviderDiscovered): callback-parameter #7242

Merged
merged 5 commits into from
Sep 9, 2024

Conversation

danforbes
Copy link
Contributor

Callback for onNewProviderDiscoveredshould have EIP6963ProvidersMapUpdateEvent parameter

Closes #7241

Callback for `onNewProviderDiscovered`should have `EIP6963ProvidersMapUpdateEvent` parameter

Closes #7241
Copy link

github-actions bot commented Sep 5, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.63 kB → 639.62 kB (-5 B) -0.00%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
../lib/commonjs/web3_eip6963.d.ts 1.28 kB → 1.28 kB (+2 B) +0.15%

Smaller

Asset File Size % Changed
../lib/commonjs/web3.d.ts 1.39 kB → 1.38 kB (-7 B) -0.49%

Unchanged

Asset File Size % Changed
web3.min.js 620.22 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: c177665 Previous: 2f24244 Ratio
processingTx 21833 ops/sec (±7.86%) 23756 ops/sec (±7.52%) 1.09
processingContractDeploy 36691 ops/sec (±10.24%) 40022 ops/sec (±7.39%) 1.09
processingContractMethodSend 14680 ops/sec (±10.24%) 16888 ops/sec (±7.21%) 1.15
processingContractMethodCall 25209 ops/sec (±9.54%) 27258 ops/sec (±8.42%) 1.08
abiEncode 42100 ops/sec (±5.71%) 44502 ops/sec (±6.85%) 1.06
abiDecode 28208 ops/sec (±10.91%) 31804 ops/sec (±6.33%) 1.13
sign 1491 ops/sec (±3.98%) 1546 ops/sec (±4.08%) 1.04
verify 363 ops/sec (±0.60%) 372 ops/sec (±0.57%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (2f24244) to head (c177665).
Report is 2 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7242   +/-   ##
=======================================
  Coverage   94.48%   94.48%           
=======================================
  Files         216      216           
  Lines        8439     8439           
  Branches     2318     2318           
=======================================
  Hits         7974     7974           
  Misses        465      465           
Flag Coverage Δ
UnitTests 94.48% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Callback for onNewProviderDiscovered Should Have EIP6963ProvidersMapUpdateEvent Parameter
2 participants