-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(requestEIP6963Providers): return-type #7239
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: afb8235 | Previous: 7a6e492 | Ratio |
---|---|---|---|
processingTx |
22978 ops/sec (±7.20% ) |
22522 ops/sec (±8.59% ) |
0.98 |
processingContractDeploy |
41096 ops/sec (±7.41% ) |
39622 ops/sec (±7.51% ) |
0.96 |
processingContractMethodSend |
16694 ops/sec (±6.96% ) |
17407 ops/sec (±7.00% ) |
1.04 |
processingContractMethodCall |
27639 ops/sec (±7.62% ) |
28383 ops/sec (±7.80% ) |
1.03 |
abiEncode |
46313 ops/sec (±6.48% ) |
46331 ops/sec (±6.95% ) |
1.00 |
abiDecode |
30843 ops/sec (±7.77% ) |
31565 ops/sec (±7.20% ) |
1.02 |
sign |
1561 ops/sec (±1.00% ) |
1592 ops/sec (±0.56% ) |
1.02 |
verify |
364 ops/sec (±2.47% ) |
371 ops/sec (±2.76% ) |
1.02 |
This comment was automatically generated by workflow using github-action-benchmark.
Add return type to requestEIP6963Providers function signature. Closes #7238
4114194
to
301cdad
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7239 +/- ##
==========================================
- Coverage 94.50% 94.48% -0.02%
==========================================
Files 216 216
Lines 8429 8439 +10
Branches 2315 2318 +3
==========================================
+ Hits 7966 7974 +8
- Misses 463 465 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Dan, also could you update changelog for EIP6963ProviderResponse
Add return type to
requestEIP6963Providers
function signature.Closes #7238