Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(requestEIP6963Providers): return-type #7239

Merged
merged 2 commits into from
Sep 9, 2024

Conversation

danforbes
Copy link
Contributor

Add return type to requestEIP6963Providers function signature.

Closes #7238

Copy link

github-actions bot commented Sep 5, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.17 kB → 639.63 kB (+469 B) +0.07%
Changeset
File Δ Size
../web3-eth-abi/lib/commonjs/decode_contract_error_data.js 📈 +1.13 kB (+56.74%) 1.99 kB → 3.12 kB
View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

Asset File Size % Changed
web3.min.js 619.88 kB → 620.22 kB (+349 B) +0.05%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB → 1.28 kB (+76 B) +6.17%
../lib/commonjs/web3.d.ts 1.35 kB → 1.39 kB (+44 B) +3.19%

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: afb8235 Previous: 7a6e492 Ratio
processingTx 22978 ops/sec (±7.20%) 22522 ops/sec (±8.59%) 0.98
processingContractDeploy 41096 ops/sec (±7.41%) 39622 ops/sec (±7.51%) 0.96
processingContractMethodSend 16694 ops/sec (±6.96%) 17407 ops/sec (±7.00%) 1.04
processingContractMethodCall 27639 ops/sec (±7.62%) 28383 ops/sec (±7.80%) 1.03
abiEncode 46313 ops/sec (±6.48%) 46331 ops/sec (±6.95%) 1.00
abiDecode 30843 ops/sec (±7.77%) 31565 ops/sec (±7.20%) 1.02
sign 1561 ops/sec (±1.00%) 1592 ops/sec (±0.56%) 1.02
verify 364 ops/sec (±2.47%) 371 ops/sec (±2.76%) 1.02

This comment was automatically generated by workflow using github-action-benchmark.

Add return type to requestEIP6963Providers function signature.

Closes #7238
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.48%. Comparing base (9b32205) to head (afb8235).
Report is 3 commits behind head on 4.x.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7239      +/-   ##
==========================================
- Coverage   94.50%   94.48%   -0.02%     
==========================================
  Files         216      216              
  Lines        8429     8439      +10     
  Branches     2315     2318       +3     
==========================================
+ Hits         7966     7974       +8     
- Misses        463      465       +2     
Flag Coverage Δ
UnitTests 94.48% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Dan, also could you update changelog for EIP6963ProviderResponse

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Return Type to requestEIP6963Providers Function Signature
2 participants