-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
unit tests update #7221
unit tests update #7221
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 0223165 | Previous: f351e00 | Ratio |
---|---|---|---|
processingTx |
22061 ops/sec (±7.48% ) |
23021 ops/sec (±8.06% ) |
1.04 |
processingContractDeploy |
40267 ops/sec (±6.83% ) |
39443 ops/sec (±6.86% ) |
0.98 |
processingContractMethodSend |
16185 ops/sec (±6.85% ) |
16703 ops/sec (±6.80% ) |
1.03 |
processingContractMethodCall |
27523 ops/sec (±6.96% ) |
27867 ops/sec (±6.76% ) |
1.01 |
abiEncode |
45461 ops/sec (±6.72% ) |
44933 ops/sec (±6.90% ) |
0.99 |
abiDecode |
30868 ops/sec (±8.53% ) |
31451 ops/sec (±6.18% ) |
1.02 |
sign |
1551 ops/sec (±3.53% ) |
1556 ops/sec (±3.34% ) |
1.00 |
verify |
372 ops/sec (±0.72% ) |
358 ops/sec (±0.76% ) |
0.96 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7221 +/- ##
=======================================
Coverage 94.50% 94.50%
=======================================
Files 216 216
Lines 8429 8429
Branches 2315 2315
=======================================
Hits 7966 7966
Misses 463 463
Flags with carried forward coverage won't be shown. Click here to find out more. |
node v18 issue: timeout increased, should not be cancelled if v20 fails. After fix all 3 attempts passed: |
Description
#7194
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.