Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unit tests update #7221

Merged
merged 7 commits into from
Aug 28, 2024
Merged

unit tests update #7221

merged 7 commits into from
Aug 28, 2024

Conversation

jdevcs
Copy link
Contributor

@jdevcs jdevcs commented Aug 26, 2024

Description

#7194

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have selected the correct base branch.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run lint with success and extended the tests and types if necessary.
  • I ran npm run test:unit with success.
  • I ran npm run test:coverage and my test cases cover all the lines and branches of the added code.
  • I ran npm run build and tested dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.
  • I have linked Issue(s) with this PR in "Linked Issues" menu.

Copy link

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 639.17 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 619.88 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: 0223165 Previous: f351e00 Ratio
processingTx 22061 ops/sec (±7.48%) 23021 ops/sec (±8.06%) 1.04
processingContractDeploy 40267 ops/sec (±6.83%) 39443 ops/sec (±6.86%) 0.98
processingContractMethodSend 16185 ops/sec (±6.85%) 16703 ops/sec (±6.80%) 1.03
processingContractMethodCall 27523 ops/sec (±6.96%) 27867 ops/sec (±6.76%) 1.01
abiEncode 45461 ops/sec (±6.72%) 44933 ops/sec (±6.90%) 0.99
abiDecode 30868 ops/sec (±8.53%) 31451 ops/sec (±6.18%) 1.02
sign 1551 ops/sec (±3.53%) 1556 ops/sec (±3.34%) 1.00
verify 372 ops/sec (±0.72%) 358 ops/sec (±0.76%) 0.96

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented Aug 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.50%. Comparing base (f351e00) to head (0223165).
Report is 1 commits behind head on 4.x.

Additional details and impacted files
@@           Coverage Diff           @@
##              4.x    #7221   +/-   ##
=======================================
  Coverage   94.50%   94.50%           
=======================================
  Files         216      216           
  Lines        8429     8429           
  Branches     2315     2315           
=======================================
  Hits         7966     7966           
  Misses        463      463           
Flag Coverage Δ
UnitTests 94.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@jdevcs
Copy link
Contributor Author

jdevcs commented Aug 26, 2024

@jdevcs jdevcs merged commit 9b32205 into 4.x Aug 28, 2024
54 checks passed
@jdevcs jdevcs deleted the junaid/unittestsupdate branch August 28, 2024 08:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants