-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix infura tests and secrets #7163
Conversation
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset No files were changed View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: 66316d2 | Previous: cbbbd84 | Ratio |
---|---|---|---|
processingTx |
8867 ops/sec (±4.98% ) |
9422 ops/sec (±3.54% ) |
1.06 |
processingContractDeploy |
39811 ops/sec (±6.52% ) |
40005 ops/sec (±6.29% ) |
1.00 |
processingContractMethodSend |
15484 ops/sec (±7.84% ) |
15941 ops/sec (±7.57% ) |
1.03 |
processingContractMethodCall |
27730 ops/sec (±7.64% ) |
27197 ops/sec (±8.39% ) |
0.98 |
abiEncode |
41599 ops/sec (±7.04% ) |
45246 ops/sec (±6.54% ) |
1.09 |
abiDecode |
28666 ops/sec (±8.42% ) |
30727 ops/sec (±7.98% ) |
1.07 |
sign |
1497 ops/sec (±3.06% ) |
1542 ops/sec (±2.93% ) |
1.03 |
verify |
361 ops/sec (±1.06% ) |
374 ops/sec (±0.56% ) |
1.04 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7163 +/- ##
=======================================
Coverage 94.46% 94.46%
=======================================
Files 215 215
Lines 8396 8396
Branches 2315 2315
=======================================
Hits 7931 7931
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
Commit 7f349fb with e2e and blackbox test cases passing |
Description
Please include a summary of the changes and be sure to follow our Contribution Guidelines.
Fixes #4058
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.