-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web3-errors): the undefined data in Eip838ExecutionError (#6905) #7147
Conversation
* fix(web3-errors): handle the undefined data in Eip838ExecutionError constructor(#6433) * doc: update changelog * Update CHANGELOG.md * Update CHANGELOG.md --------- Co-authored-by: Muhammad Altabba <[email protected]> Co-authored-by: Junaid <[email protected]>
Bundle StatsHey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
Changeset
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger
Smaller No assets were smaller Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Benchmark
Benchmark suite | Current: e793cc5 | Previous: 463d070 | Ratio |
---|---|---|---|
processingTx |
9330 ops/sec (±3.46% ) |
9085 ops/sec (±3.80% ) |
0.97 |
processingContractDeploy |
39389 ops/sec (±7.42% ) |
39873 ops/sec (±6.00% ) |
1.01 |
processingContractMethodSend |
16176 ops/sec (±8.93% ) |
15649 ops/sec (±9.76% ) |
0.97 |
processingContractMethodCall |
28238 ops/sec (±6.46% ) |
27135 ops/sec (±6.88% ) |
0.96 |
abiEncode |
44978 ops/sec (±6.89% ) |
43610 ops/sec (±6.72% ) |
0.97 |
abiDecode |
30337 ops/sec (±8.13% ) |
29967 ops/sec (±8.45% ) |
0.99 |
sign |
1525 ops/sec (±3.05% ) |
1496 ops/sec (±3.20% ) |
0.98 |
verify |
374 ops/sec (±0.44% ) |
374 ops/sec (±0.41% ) |
1 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 4.x #7147 +/- ##
=======================================
Coverage 94.45% 94.45%
=======================================
Files 215 215
Lines 8391 8391
Branches 2313 2313
=======================================
Hits 7926 7926
Misses 465 465
Flags with carried forward coverage won't be shown. Click here to find out more. |
Description
Fixes #6433
process the undefined data in Eip838ExecutionError constructor to avoid an "read something from undefined" bug.
(This PR is created for merging #6905 into 4.x)
Type of change
Checklist:
npm run lint
with success and extended the tests and types if necessary.npm run test:unit
with success.npm run test:coverage
and my test cases cover all the lines and branches of the added code.npm run build
and testeddist/web3.min.js
in a browser.CHANGELOG.md
file in the root folder.