Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs): contract-tutorial-hardhat-node #7076

Merged
merged 4 commits into from
Jun 5, 2024

Conversation

danforbes
Copy link
Contributor

@danforbes danforbes commented May 30, 2024

  • Ganache has been deprecated, use Hardhat
  • Use JavaScript instead of TypeScript
  • The basic smart contract guide should come before Mastering Smart Contracts
  • Improvements (more links, formatting/consistency) and simplifications

This uses a persistent Hardhat development network and would replace #7075

@danforbes danforbes changed the title Contract Tutorial Fixes fix(docs): contract-tutorial-hardhat-node May 30, 2024
Copy link

github-actions bot commented May 30, 2024

Bundle Stats

Hey there, this message comes from a GitHub action that helps you and reviewers to understand how these changes affect the size of this project's bundle.

As this PR is updated, I'll keep you updated on how the bundle size is impacted.

Total

Files count Total bundle size % Changed
10 630.32 kB 0%

Changeset

No files were changed

View detailed bundle breakdown

Added

No assets were added

Removed

No assets were removed

Bigger

No assets were bigger

Smaller

No assets were smaller

Unchanged

Asset File Size % Changed
web3.min.js 611.03 kB 0%
../lib/commonjs/index.d.ts 8.69 kB 0%
../lib/commonjs/accounts.d.ts 3.89 kB 0%
../lib/commonjs/types.d.ts 2.67 kB 0%
../lib/commonjs/web3.d.ts 1.35 kB 0%
../lib/commonjs/web3_eip6963.d.ts 1.2 kB 0%
../lib/commonjs/abi.d.ts 999 B 0%
../lib/commonjs/eth.exports.d.ts 280 B 0%
../lib/commonjs/providers.exports.d.ts 183 B 0%
../lib/commonjs/version.d.ts 60 B 0%

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Benchmark

Benchmark suite Current: e3c00a0 Previous: a7d67c6 Ratio
processingTx 9150 ops/sec (±3.47%) 9004 ops/sec (±4.26%) 0.98
processingContractDeploy 37287 ops/sec (±7.51%) 38832 ops/sec (±7.40%) 1.04
processingContractMethodSend 18829 ops/sec (±6.55%) 18670 ops/sec (±7.23%) 0.99
processingContractMethodCall 37877 ops/sec (±5.23%) 37139 ops/sec (±5.60%) 0.98
abiEncode 43324 ops/sec (±7.05%) 43522 ops/sec (±6.91%) 1.00
abiDecode 30363 ops/sec (±6.55%) 29115 ops/sec (±7.30%) 0.96
sign 1520 ops/sec (±4.03%) 1597 ops/sec (±0.97%) 1.05
verify 371 ops/sec (±0.52%) 369 ops/sec (±0.66%) 0.99

This comment was automatically generated by workflow using github-action-benchmark.

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.98%. Comparing base (4358140) to head (a6fe2d9).
Report is 260 commits behind head on 4.x.

Current head a6fe2d9 differs from pull request most recent head e3c00a0

Please upload reports for the commit e3c00a0 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #7076      +/-   ##
==========================================
+ Coverage   87.37%   93.98%   +6.61%     
==========================================
  Files         197      215      +18     
  Lines        7548     8335     +787     
  Branches     2059     2301     +242     
==========================================
+ Hits         6595     7834    +1239     
+ Misses        953      501     -452     
Flag Coverage Δ
UnitTests 93.98% <ø> (+6.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

- Ganache has been deprecated, use Hardhat
- Use JavaScript instead of TypeScript
- Improvements (more links, formatting/consistency) and simplifications
Any funds sent to them on Mainnet or any other live network WILL BE LOST.

Account #0: 0xf39Fd6e51aad88F6F4ce6aB8827279cffFb92266 (10000 ETH)
Private Key: 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually when we deal with docs and private keys, we want to hide the actual private keys in case theres a beginner who decides to reuse an exposed key

Suggested change
Private Key: 0xac0974bec39a17e36ba4a6b4d238ff944bacb478cbed5efcae784d7bf4f2ff80
Private Key: privateKey

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it...thank you!

@danforbes danforbes merged commit 9fe4eb2 into 4.x Jun 5, 2024
14 of 18 checks passed
@danforbes danforbes deleted the fix/docs/contracts-tutorial-hardhat-node branch June 5, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants