Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: create resources page #6824

Merged
merged 8 commits into from
Feb 27, 2024
Merged

docs: create resources page #6824

merged 8 commits into from
Feb 27, 2024

Conversation

omahs
Copy link
Contributor

@omahs omahs commented Feb 21, 2024

docs: create resources page #6821

@omahs
Copy link
Contributor Author

omahs commented Feb 21, 2024

@SantiagoDevRel
It seems to me that the .yml file is only needed if there are multiple pages in the category.
The Glossary page for example doesn't include it

@omahs omahs marked this pull request as draft February 21, 2024 18:20
Copy link

codecov bot commented Feb 21, 2024

Codecov Report

Merging #6824 (5473e0b) into 4.x (4358140) will increase coverage by 4.66%.
Report is 181 commits behind head on 4.x.
The diff coverage is n/a.

❗ Current head 5473e0b differs from pull request most recent head 2b4e7c5. Consider uploading reports for the commit 2b4e7c5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##              4.x    #6824      +/-   ##
==========================================
+ Coverage   87.37%   92.04%   +4.66%     
==========================================
  Files         197      214      +17     
  Lines        7548     8192     +644     
  Branches     2059     2206     +147     
==========================================
+ Hits         6595     7540     +945     
+ Misses        953      652     -301     
Flag Coverage Δ
UnitTests 92.04% <ø> (+4.66%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
web3 ∅ <ø> (∅)
web3-core ∅ <ø> (∅)
web3-errors ∅ <ø> (∅)
web3-eth ∅ <ø> (∅)
web3-eth-abi ∅ <ø> (∅)
web3-eth-accounts ∅ <ø> (∅)
web3-eth-contract ∅ <ø> (∅)
web3-eth-ens ∅ <ø> (∅)
web3-eth-iban ∅ <ø> (∅)
web3-eth-personal ∅ <ø> (∅)
web3-net ∅ <ø> (∅)
web3-providers-http ∅ <ø> (∅)
web3-providers-ipc ∅ <ø> (∅)
web3-providers-ws ∅ <ø> (∅)
web3-rpc-methods ∅ <ø> (∅)
web3-utils ∅ <ø> (∅)
web3-validator ∅ <ø> (∅)

@SantiagoDevRel
Copy link
Member

You are right, @omahs i was thinking to have a folder to add later files to it, but in this case, a simple file is also fine since we can just add all the resources in 1 file. thanks. I think this is ready for review?
Btw, i'm not sure if its intuitive that you should click on the image to go the youtube video, maybe add the link in the title or something as well?

@SantiagoDevRel
Copy link
Member

SantiagoDevRel commented Feb 23, 2024

Or actually, if we create a Resources folder, we can include learning resources and current bounties/hackathons we are hosting?
so it will be like:

-Resources
--Learning resources
--Hackathon

or just include the current hackathon in the main 'resources' file or not include it at all (and only ,mention those events on twitter/discord), wdy think? @jdevcs
and also pls share ur opinion about this @omahs , would u like to see current hackathons for web3.js listed here or the docs is not the right place for it?

@omahs
Copy link
Contributor Author

omahs commented Feb 23, 2024

@SantiagoDevRel Just added the links to the title
For the hackathons, the downside is that it needs to be checked and updated regularly, will wait for @jdevcs answer too

@jdevcs
Copy link
Contributor

jdevcs commented Feb 26, 2024

@SantiagoDevRel Just added the links to the title For the hackathons, the downside is that it needs to be checked and updated regularly, will wait for @jdevcs answer too

you are right, for hackathons if this section is added it will need regular updates, may be add web3.js twitter badge for updates.

@omahs
Copy link
Contributor Author

omahs commented Feb 26, 2024

Thanks for your feedbacks! @SantiagoDevRel @jdevcs
Added one part about hackathons

Copy link
Contributor

@jdevcs jdevcs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, @omahs this PR is ready?

@omahs
Copy link
Contributor Author

omahs commented Feb 27, 2024

@jdevcs yup, ready!

@jdevcs jdevcs marked this pull request as ready for review February 27, 2024 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants