This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Handling of the "null" response from provider #5324
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nazarhussain
requested review from
Muhammad-Altabba,
avkos,
jdevcs,
luu-alex,
nikoulai and
spacesailor24
|
Your Render PR Server URL is https://web3js-docs-pr-5324.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-cbnge89a6gdvvu1kcgtg. |
1 task
avkos
approved these changes
Aug 8, 2022
jdevcs
reviewed
Aug 8, 2022
| response: JsonRpcResponse<ResultType, ErrorType>, | ||
| { legacy, error }: { legacy: boolean; error: boolean }, | ||
| ): JsonRpcResponse<ResultType> | never { | ||
| if (isNullish(response)) { |
Contributor
There was a problem hiding this comment.
can you share rpc request and eth node you used for this case?
Contributor
Author
There was a problem hiding this comment.
It was tested for eth_getTransactionReceipt with ganache for a transaction hash which is not part of the block yet.
jdevcs
approved these changes
Aug 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #5319
Type of change
Checklist:
npm run dtslintwith success and extended the tests and types if necessary.npm run test:covand my test cases cover all the lines and branches of the added code.npm run buildwith success.dist/web3.min.jsin a browser.CHANGELOG.mdfile in the root folder.