Skip to content
This repository was archived by the owner on Mar 5, 2025. It is now read-only.

Fix transactionsRoot in BlockHeader#5197

Merged
jdevcs merged 1 commit into
1.xfrom
junaid/txrootfix
Jul 4, 2022
Merged

Fix transactionsRoot in BlockHeader#5197
jdevcs merged 1 commit into
1.xfrom
junaid/txrootfix

Conversation

@jdevcs
Copy link
Copy Markdown
Contributor

@jdevcs jdevcs commented Jul 4, 2022

Description

This PR is for testing failing CI in #5083

Please include a summary of the changes and be sure to follow our Contribution Guidelines.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I ran npm run dtslint with success and extended the tests and types if necessary.
  • I ran npm run test:cov and my test cases cover all the lines and branches of the added code.
  • I ran npm run build with success.
  • I have tested the built dist/web3.min.js in a browser.
  • I have tested my code on the live network.
  • I have checked the Deploy Preview and it looks correct.
  • I have updated the CHANGELOG.md file in the root folder.

@OscBacon @nikoulai @jdevcs
Fix transactionRoot -> transactionsRoot in BlockHeader (#5083)
4b6e9ec 
* Fix transactionRoot -> transactionsRoot in BlockHeader

* Update CHANGELOG.md

Co-authored-by: Nikos Iliakis <nikoulai@users.noreply.github.com>
Co-authored-by: Junaid <86780488+jdevcs@users.noreply.github.com>
@jdevcs jdevcs self-assigned this Jul 4, 2022
@render
Copy link
Copy Markdown

render Bot commented Jul 4, 2022

Your Render PR Server URL is https://web3-js-pr-5197.onrender.com.

Follow its progress at https://dashboard.render.com/static/srv-cb1ecokgqg45rlgbnmt0.

@coveralls
Copy link
Copy Markdown

coveralls commented Jul 4, 2022

Pull Request Test Coverage Report for Build 2610289874

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 72.043%
Totals Coverage Status
Change from base Build 2609546647: 0.0%
Covered Lines: 3394
Relevant Lines: 4436
💛 - Coveralls

@jdevcs
Copy link
Copy Markdown
Contributor Author

jdevcs commented Jul 4, 2022

Merging it, as changes in this PR are already approved in #5083 and all CI checks are passing in current PR

@jdevcs jdevcs merged commit 2a1308f into 1.x Jul 4, 2022
@jdevcs jdevcs deleted the junaid/txrootfix branch July 4, 2022 13:40
@jdevcs jdevcs mentioned this pull request Jul 4, 2022
Merged
@snyk-bot snyk-bot mentioned this pull request Aug 22, 2022
Open
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@jdevcs jdevcs

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@jdevcs @coveralls @OscBacon