This repository was archived by the owner on Mar 5, 2025. It is now read-only.
4969/account wallet docs #5164
Merged
4969/account wallet docs #5164
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikoulai
reviewed
Jun 28, 2022
nazarhussain
approved these changes
Jun 29, 2022
nikoulai
approved these changes
Jun 29, 2022
jdevcs
suggested changes
Jun 29, 2022
jdevcs
reviewed
Jun 29, 2022
jdevcs
reviewed
Jun 29, 2022
jdevcs
reviewed
Jun 29, 2022
jdevcs
reviewed
Jun 29, 2022
jdevcs
reviewed
Jun 29, 2022
jdevcs
suggested changes
Jun 29, 2022
|
LGTM, except some minor changes. |
jdevcs
approved these changes
Jun 30, 2022
avkos
approved these changes
Jun 30, 2022
|
created issue for function that is not returning expected type. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#4969
Description
This PR is for the documentation of both wallets and account.
It also includes some bug fixes I discovered when making the documentation:
booleansrcfile instead of just the compiled files