This repository was archived by the owner on Mar 5, 2025. It is now read-only.
eth_createAccessList - Closes #4081#4332
Merged
Merged
Conversation
|
Your Render PR Server URL is https://web3-js-pr-4332.onrender.com. Follow its progress at https://dashboard.render.com/static/srv-c51fn4s6fj3626qo74r0. |
Contributor
Author
|
Docs for this method were added here, but the PR was reverted. The subsequent PR to add back the docs was closed, and there doesn't seem to be anything adding it to the mentioned repo So I'm operating under the assumption that |
Contributor
Author
|
I've tested that this works as expected using this repo Access list generated by these changes: {
"accessList": [
{
"address": "0x35288259dc7fd6a6986cb3827965a4b711f73d81",
"storageKeys": [
"0x0000000000000000000000000000000000000000000000000000000000000002",
"0x405787fa12a823e0f2b7631cc41b3ba8828b3321ca811111fa75cd3aa3bb5ad0",
"0x405787fa12a823e0f2b7631cc41b3ba8828b3321ca811111fa75cd3aa3bb5ad1"
]
}
],
"gasUsed": "0x76ee"
}Access list by submitting the same transaction directly to Geth: {
"jsonrpc": "2.0",
"id": 1,
"result": {
"accessList": [
{
"address": "0x35288259dc7fd6a6986cb3827965a4b711f73d81",
"storageKeys": [
"0x0000000000000000000000000000000000000000000000000000000000000002",
"0x405787fa12a823e0f2b7631cc41b3ba8828b3321ca811111fa75cd3aa3bb5ad0",
"0x405787fa12a823e0f2b7631cc41b3ba8828b3321ca811111fa75cd3aa3bb5ad1"
]
}
],
"gasUsed": "0x76ee"
}
} |
Spacesai1or
commented
Sep 18, 2021
Spacesai1or
commented
Sep 18, 2021
Spacesai1or
commented
Sep 18, 2021
Spacesai1or
commented
Sep 18, 2021
Spacesai1or
commented
Sep 18, 2021
Spacesai1or
commented
Sep 18, 2021
jdevcs
reviewed
Sep 20, 2021
nazarhussain
previously approved these changes
Sep 20, 2021
Contributor
nazarhussain
left a comment
There was a problem hiding this comment.
Apart from the feedback of @jdevcs LGTM.
jdevcs
previously approved these changes
Sep 22, 2021
|
Ok |
This was referenced Feb 11, 2022
This was referenced Mar 24, 2022
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
createAccessListtoweb3.eth(web3.eth.createAccessList)createAccessListto contract method wrapperscontract.methods.myMethod(some, parameters).createAccessList({ from: '0x0...' })I believe only Geth supports
eth_createAccessListright now, but I'm not sureCloses #4081