Split encoder and normalizer to fix Symfony 6.1 compatibility #347
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Hang on, I see I need to update the tests, oops. |
Rector fixes More style fixes
Contributor
Author
|
Fixed the tests, some checks (still) fail but are outside the scope of this PR and are caused by things not touched by this PR. |
Member
Contributor
Author
|
@Spomky Yep, though I encountered other issues later on not related to your package (afaik). When I have time I might dig deeper as the problem lies with Symfony I bet. For now, this fix won't harm anyone and it seems to fix compatibility with 6.1. |
Member
|
@mdeboer no worries, the remaining errors are only related to PHPStan. As the level is set to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Symfony starting from 6.1 doesn't seem to like when you combine an encoder and a normalizer. This might be a bug in Symfony but the easiest fix is just to separate the two, which is what I did.