created universal controller that reconciles all resources related to… #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… magento.web7.md, allowing manage of resources from magento API based on standard RESTful API definitions
ca7alindev
force-pushed
the
6-universal-controller-for-generated-magento-crds
branch
from
fa7a756
to
99d672f
Compare
evghen1
requested changes
May 23, 2024
… to beginning of file
evghen1
requested changes
May 24, 2024
evghen1
requested changes
May 30, 2024
internal/controller/magento.go
Outdated
|
|
||
| // isValidGVK returns true if the GroupVersionKind is a valid Magento API resource. | ||
| func isValidGVK(gvk schema.GroupVersionKind) bool { | ||
| return gvk.Group == "magento.web7.md" && gvk.Version == "v1alpha1" && |
There was a problem hiding this comment.
@ca7alindev Please move Group and Version to constants.
internal/client/magento.go
Outdated
| if id == "" { | ||
| return nil, errors.New("resource with ID" + id + " in " + c.Path + " not found") | ||
| } | ||
| resp, _ := c.Create().R().Get(c.Path + "/" + id) |
There was a problem hiding this comment.
@ca7alindev Separators to constants please.
|
@ca7alindev Ready for review? |
ready |
evghen1
approved these changes
May 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ed on standard RESTful API definitions