Still requires GMP

[senky]

README says:

gmp (optional but better for performance)

but the code still triggers warning:

web-push-php/src/WebPush.php

Lines 73 to 81 in eddd95c

	'gmp' => '[WebPush] gmp extension is not loaded but is required for sending push notifications with payload or for VAPID authentication. You can fix this in your php.ini.',
	'mbstring' => '[WebPush] mbstring extension is not loaded but is required for sending push notifications with payload or for VAPID authentication. You can fix this in your php.ini.',
	'openssl' => '[WebPush] openssl extension is not loaded but is required for sending push notifications with payload or for VAPID authentication. You can fix this in your php.ini.',
	];
	foreach ($extensions as $extension => $message) {
	if (!extension_loaded($extension)) {
	trigger_error($message, E_USER_WARNING);
	}
	}

What's the real status with GMP?

[askvortsov1]

Would also appreciate some clarity on this: not requiring GMP would be huge for adoption in my use case.

[marc1706]

Based on my testing, web-push-php does work fine without GMP on PHP 7.3+. This is mostly due to PHP 7.3+ using openssl_pkey_derive instead of the pure PHP implementation (which does not work, see e.g. this test run: https://github.com/marc1706/web-push-php/runs/2156729472).

[askvortsov1]

Ah great, thanks for the testing! PHP 7.2 is EOL anyways, so this is excellent news.

[marc1706]

Since I showed you that 7.2 does not work, here actually an example that unit tests start working with PHP 7.3 (only phpstan issues left): https://github.com/marc1706/web-push-php/runs/2607203285?check_suite_focus=true

[Azuxul]

I it is possible to add a check for the php version and only require gmp in case of php<7.3 ?