Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vapid01 instance is not accepted as a key object #137

Closed
mthu opened this issue Jul 26, 2021 · 0 comments
Closed

Vapid01 instance is not accepted as a key object #137

mthu opened this issue Jul 26, 2021 · 0 comments

Comments

@mthu
Copy link
Contributor

mthu commented Jul 26, 2021 •
edited
Loading

Since Vapid01 is a superclass of Vapid02 (and thus Vapid) in py_vapid library, following condition does not match the Vapid01 instance and the ongoing code treats the object as a string (and fails parsing it).

pywebpush/pywebpush/__init__.py

Line 461 in a2dbc6f

if isinstance(vapid_private_key, Vapid):

@mthu mthu mentioned this issue Jul 26, 2021
Merged
jrconlin pushed a commit that referenced this issue Jul 27, 2021
@mthu
fix accepting all Vapid key instances (#137) (#139)
248cd43 
confirmed source change
@mthu mthu closed this as completed Jul 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mthu