WPT, Forms, FileAPI: Fix upload filenames with controls & punctuation #8618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
approved these changes
Dec 7, 2017
Collaborator
wpt-pr-bot
left a comment
wpt-pr-bot
left a comment
There was a problem hiding this comment.
Already reviewed downstream.
Build PASSEDStarted: 2017-12-09 01:01:22 View more information about this build on: |
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-814400
branch
from
1d8600f to
11cd2f5
Compare
chromium-wpt-export-bot
changed the title
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-814400
branch
2 times, most recently
from
0a48b63 to
39b79ca
Compare
The tests are `.tentative.` until I'm certain they are in agreement with HTML. See also https://github.com/whatwg/html/pull/3276/files and whatwg/html#3276 (comment) Change-Id: Ic94768ad642a2926ed9c0270faa2b83f856425a9
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-814400
branch
from
39b79ca to
49b0b9b
Compare
Member
|
Manually closing this PR. The Chromium CL is no longer active, and this PR is too old for our WPT export infrastructure to find it, so we end up trying to create a new branch with the same name, push it and fail. |
annevk
pushed a commit
that referenced
this pull request
Nov 18, 2020
This PR adds tests for forms containing controls and punctuation, both on multipart/form-data request bodies and on FormData objects. This is in part a modification of #8618, which got closed downstream due to inactivity. Co-Authored-By: Benjamin C. Wiley Sittler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The tests are
.tentative.until I'm certain they are in agreementwith HTML. See also
https://github.com/whatwg/html/pull/3276/files
and
whatwg/html#3276 (comment)
Change-Id: Ic94768ad642a2926ed9c0270faa2b83f856425a9
Reviewed-on: https://chromium-review.googlesource.com/814400
WPT-Export-Revision: 2e62dcbc1b32921a2edc0d245ec49c910278a3bf