Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Link to all HTML-related tests from html/README.md #7309

Merged
merged 6 commits into from
Sep 24, 2017
Merged

Link to all HTML-related tests from html/README.md #7309

merged 6 commits into from
Sep 24, 2017

Conversation

foolip
Copy link
Member

@foolip foolip commented Sep 10, 2017 •
edited by wpt-pr-bot
Loading

Part of whatwg/html#3014.

@foolip foolip requested review from domenic and annevk and removed request for jdm, zcorpan, jgraham and zqzhang September 10, 2017 21:04
@foolip
Copy link
Member Author

foolip commented Sep 10, 2017

@annevk, FYI, custom-elements is the only thing listed that doesn't have a README of the shape you made in #5385. Maybe it should?

@ghost
Copy link

ghost commented Sep 10, 2017 •
edited by ghost
Loading

Build PASSED

Started: 2017-09-23 23:34:18
Finished: 2017-09-23 23:37:21

View more information about this build on:

domenic
domenic reviewed Sep 10, 2017
View reviewed changes
Copy link
Member

@domenic domenic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It'd be nice if these were links, like the webappapis/atob above them?

@foolip
Copy link
Member Author

foolip commented Sep 11, 2017

Now linked. I don't know if there's much point in the leading slashes, I copied the style from XMLHttpRequest/README.md.

annevk
annevk reviewed Sep 11, 2017
View reviewed changes
html/README.md Outdated
@@ -5,3 +5,15 @@ This directory contains tests for [HTML](https://html.spec.whatwg.org/multipage/
Sub-directory names should be based on the URL of the corresponding part of the
multipage-version specification. For example, The URL of
"8.3 Base64 utility methods" is [https://html.spec.whatwg.org/multipage/webappapis.html#atob](https://html.spec.whatwg.org/multipage/webappapis.html#atob). So the directory in WPT is [webappsapis/atob/](webappsapis/atob).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix this link to webappapis/atob while here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I didn't notice it was broken, will fix.

@annevk
Copy link
Member

annevk commented Sep 11, 2017

@foolip yeah, I think custom-elements should have that too. Though it needs to point to both DOM and HTML.

The same applies to /shadow-dom btw which you seem to have forgotten about here?

@zcorpan
Copy link
Member

zcorpan commented Sep 11, 2017

Added innerText in a new commit.

@zcorpan zcorpan mentioned this pull request Sep 11, 2017
Closed
@foolip
Copy link
Member Author

foolip commented Sep 11, 2017

@annevk @zcorpan, shadow DOM is part of DOM, not HTML, right?

@annevk
Copy link
Member

annevk commented Sep 11, 2017

Both. <slot> is in HTML for instance, as are many modifications to how HTML deals with things, e.g., around <link> and <dialog>.

@foolip
Copy link
Member Author

foolip commented Sep 23, 2017

@zcorpan already added shadow-dom too, awesome!

I think custom-elements should have that too. Though it needs to point to both DOM and HTML.

I haven't done it in this PR, will do it separately.

@annevk annevk merged commit b47289f into master Sep 24, 2017
@annevk annevk deleted the html-readme branch September 24, 2017 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annevk annevk annevk left review comments

@domenic domenic domenic approved these changes

@jdm jdm Awaiting requested review from jdm

@jgraham jgraham Awaiting requested review from jgraham

@zcorpan zcorpan Awaiting requested review from zcorpan

@zqzhang zqzhang Awaiting requested review from zqzhang

Assignees
No one assigned
Labels
html
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@foolip @annevk @zcorpan @domenic @wpt-pr-bot