Skip to content

Make reftests wait for fonts to load over WebDriver#6558

Merged
jgraham merged 3 commits intoweb-platform-tests:masterfrom
gsnedders:reftest-wait-font
Jul 18, 2017
Merged

Make reftests wait for fonts to load over WebDriver#6558
jgraham merged 3 commits intoweb-platform-tests:masterfrom
gsnedders:reftest-wait-font

Conversation

@gsnedders
Copy link
Member

@gsnedders gsnedders commented Jul 14, 2017

Fixes #6328. Fixes #5412. Fixes, partially, #6327.

This doesn't change the Martionette script as per w3c/csswg-drafts#1088 (comment) Firefox blocks the load event on fonts loading.


This change is Reviewable

@wpt-pr-bot wpt-pr-bot requested review from bobholt and jgraham July 14, 2017 16:13
@gsnedders gsnedders force-pushed the reftest-wait-font branch from 1e9f86a to 9ee37f6 Compare July 14, 2017 16:16
@ghost
Copy link

ghost commented Jul 14, 2017

View the complete job log.

Firefox (nightly)

Testing web-platform-tests at revision 9d65700
Using browser at version BuildID 20170714100217; SourceStamp 67cd1ee26f2661fa5efe3d952485ab3c89af4271
Starting 10 test iterations
No tests run.

@ghost
Copy link

ghost commented Jul 14, 2017

View the complete job log.

Sauce (safari)

Testing web-platform-tests at revision 9d65700
Using browser at version 10.0
Starting 10 test iterations
No tests run.

@ghost
Copy link

ghost commented Jul 14, 2017

View the complete job log.

Chrome (unstable)

Testing web-platform-tests at revision 65e7d89
Using browser at version 61.0.3153.4 dev
Starting 10 test iterations
No tests run.

@ghost
Copy link

ghost commented Jul 14, 2017

View the complete job log.

Sauce (MicrosoftEdge)

Testing web-platform-tests at revision 65e7d89
Using browser at version 14.14393
Starting 10 test iterations
No tests run.

@bobholt
Copy link
Contributor

bobholt commented Jul 14, 2017

This looks good to me, but I'd like to wait for @jgraham to weigh in on how we make sure it doesn't break Servo.

@jdm
Copy link
Contributor

jdm commented Jul 14, 2017

These changes will not break Servo.

@sideshowbarker
Copy link
Member

w3c-test:mirror

@jgraham
Copy link
Contributor

jgraham commented Jul 18, 2017

Reviewed 6 of 6 files at r1.
Review status: :shipit: all files reviewed at latest revision, all discussions resolved, all commit checks successful.


Comments from Reviewable

@jgraham jgraham merged commit de000b5 into web-platform-tests:master Jul 18, 2017
@gsnedders gsnedders deleted the reftest-wait-font branch October 5, 2017 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants