-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add checks for "navigator.language/s" to tests for "emulation.setLocaleOverride" command. #55453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add checks for "navigator.language/s" to tests for "emulation.setLocaleOverride" command. #55453
Conversation
…leOverride" command.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sasha, I feel like there is something wrong with the usage of the fixture to check the default values. It probably predates the PR, but can you check?
Co-authored-by: Julian Descottes <[email protected]>
Co-authored-by: Julian Descottes <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Sasha, LGTM, one minor suggestion.
Co-authored-by: Julian Descottes <[email protected]>
|
Closing in favour of #55768. |
Tests to illustrate how the API will work for the PR in the html spec.
More tests will be updated during work on https://bugzilla.mozilla.org/show_bug.cgi?id=1994396.