Support PaintTimingMixin in LCP #49703
Open
+20
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This make the implementation look very close to https://w3c.github.io/paint-timing/#mark-paint-timing The render coarsening and queuing logic is all consolidated into PaintTiming::MarkPaintTimingInternal. Also previous alignment mechanisms such as the buffer in WindowPerformance and clamping to FCP are no longer needed. Bug: 381270287 Change-Id: I9ef0a1ebbc9417e2d65415712fbbb554df64d8d3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087964 Reviewed-by: Michal Mocny <[email protected]> Commit-Queue: Noam Rosenthal <[email protected]> Cr-Commit-Position: refs/heads/main@{#1396678}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-6087964
branch
from
1189101 to
628750c
Compare
wpt-pr-bot
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This make the implementation look very close to
https://w3c.github.io/paint-timing/#mark-paint-timing
The render coarsening and queuing logic is all consolidated
into PaintTiming::MarkPaintTimingInternal.
Also previous alignment mechanisms such as the buffer in
WindowPerformance and clamping to FCP are no longer needed.
Bug: 381270287
Change-Id: I9ef0a1ebbc9417e2d65415712fbbb554df64d8d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/6087964
Reviewed-by: Michal Mocny <[email protected]>
Commit-Queue: Noam Rosenthal <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1396678}