Reinitialize BrowserManager's command queue after it is recreated #49693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will allow init_failed message be sent back to TestRunnerManager if timeout happens when start the browser. Also set the start browser timeout value to 65 seconds to align with the default browser startup timeout value. Bug: 381944656
wpt-pr-bot
added
infra
wptrunner
jonathan-j-lee
approved these changes
Dec 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will allow init_failed message be sent back to TestRunnerManager if timeout happens when start the browser. Previously when init retry happens, as the subsuite and test type did not change, the init process will not recreate the BrowserManager instance, causing a stale command queue be used and init_failed message won't be able to send to TestRunnerManager.
Also set the start browser timeout value to 65 seconds to align with the default browser startup timeout value.
Bug: 381944656