WebCrypto: Add test cases for deriveBits with too large and non-multiple of 8 lengths #48471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
javifernandez
force-pushed
the
derive-bits-length-too-big
branch
from
a35dc6d to
06b245b
Compare
twiss
reviewed
Oct 22, 2024
| @@ -9,25 +9,33 @@ var algorithms = { | |||
| privateKey: {format: "raw", data: rawKey}, | |||
| deriveAlg: {name: "HKDF", salt: salt, hash: "SHA-256", info: info}, | |||
| derivation: new Uint8Array([49, 183, 214, 133, 48, 168, 99, 231, 23, 192, 129, 202, 105, 23, 182, 134, 80, 179, 221, 154, 41, 243, 6, 6, 226, 202, 209, 153, 190, 193, 77, 19]), | |||
| derivation384: new Uint8Array([49, 183, 214, 133, 48, 168, 99, 231, 23, 192, 129, 202, 105, 23, 182, 134, 80, 179, 221, 154, 41, 243, 6, 6, 226, 202, 209, 153, 190, 193, 77, 19, 165, 50, 181, 8, 254, 59, 122, 199, 25, 224,146, 248, 105, 105, 75, 84]), | |||
| derivation230: new Uint8Array([]), | |||
There was a problem hiding this comment.
Bit nitpicky but perhaps we should make this one undefined as well (and same for the others)? Otherwise it may look a bit confusing here, like we're expecting an empty Uint8Array for 230 bits or so.
Suggested change
| derivation230: new Uint8Array([]), | |
| derivation230: undefined, |
(or we could just remove it altogether?)
There was a problem hiding this comment.
Good suggestion, thanks.
Comment on lines
22
to
32
| {length: 384, expected: undefined}, // should throw an exception, bigger than the key size | ||
| {length: 230, expected: algorithms["ECDH"].derivation230}, | ||
| {length: 0, expected: emptyArray}, | ||
| {length: null, expected: algorithms["ECDH"].derivation}, | ||
| {length: undefined, expected: algorithms["ECDH"].derivation}, | ||
| {length: "omitted", expected: algorithms["ECDH"].derivation }, // default value is null | ||
| ], | ||
| "X25519": [ | ||
| {length: 256, expected: algorithms["X25519"].derivation}, | ||
| {length: 384, expected: undefined}, // should throw an exception, bigger than the key size | ||
| {length: 230, expected: algorithms["X25519"].derivation230}, |
There was a problem hiding this comment.
Suggested change
| {length: 384, expected: undefined}, // should throw an exception, bigger than the key size | |
| {length: 230, expected: algorithms["ECDH"].derivation230}, | |
| {length: 0, expected: emptyArray}, | |
| {length: null, expected: algorithms["ECDH"].derivation}, | |
| {length: undefined, expected: algorithms["ECDH"].derivation}, | |
| {length: "omitted", expected: algorithms["ECDH"].derivation }, // default value is null | |
| ], | |
| "X25519": [ | |
| {length: 256, expected: algorithms["X25519"].derivation}, | |
| {length: 384, expected: undefined}, // should throw an exception, bigger than the key size | |
| {length: 230, expected: algorithms["X25519"].derivation230}, | |
| {length: 384, expected: undefined}, // should throw an exception, bigger than the output size | |
| {length: 230, expected: algorithms["ECDH"].derivation230}, | |
| {length: 0, expected: emptyArray}, | |
| {length: null, expected: algorithms["ECDH"].derivation}, | |
| {length: undefined, expected: algorithms["ECDH"].derivation}, | |
| {length: "omitted", expected: algorithms["ECDH"].derivation }, // default value is null | |
| ], | |
| "X25519": [ | |
| {length: 256, expected: algorithms["X25519"].derivation}, | |
| {length: 384, expected: undefined}, // should throw an exception, bigger than the output size | |
| {length: 230, expected: algorithms["X25519"].derivation230}, |
javifernandez
force-pushed
the
derive-bits-length-too-big
branch
from
06b245b to
738c993
Compare
twiss
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.