Digital Credentials: test create and get #46642

marcoscaceres · 2024-06-06T05:41:46Z

Creates a spec compliant set of test case and adds a more robust/flexible cross-origin testing framework:

helper.js
iframe.html

Removes/refactors the old "digital-credentials/digital-credentials.tentative.https.html", as these were not spec compliant.

Adds TypeScript types, for better workflow in VS Code, etc.

wpt-pr-bot · 2024-06-06T05:41:57Z

There are no reviewers for this pull request besides its author. Please reach out on the chat room to get help with this. Thank you!

digital-credentials/identity-get.tentative.https.html

samuelgoto · 2024-06-12T17:08:50Z

digital-credentials/digital-credentials.tentative.https.html

-  let request = buildValidNavigatorIdentityRequest();
-  let credential = await requestIdentityWithActivation(test_driver, request);
-  assert_equals("urn:openid.net:oid4vp", credential.protocol);
-  assert_equals("fake_test_token", credential.data);


It is a little unfortunate that we are removing this test, since it is what's helping us avoid regressions. Why does this need to be removed?

These don't adhere to the spec. For example, "urn:openid.net:oid4vp" is not a thing that we have settled on and, per spec, it's impossible to get a credential without the user interacting with the credential selection sheet (hence the promise would never resolve with a credential).

We need a separate WebDriver API that can vend credentials if we want something like this.

Obviously, the test would be fine an internal Chrome unit test, but it's not something that helps us here with interop.

Make sense?

For example, "urn:openid.net:oid4vp" is not a thing that we have settled on

The protocol is a DOMString rather than an enum, so I wasn't thinking that we would necessarily need to settle on its value.

It is also what's being used by the OpenID4VP pull request, so a reasonable approximation of what I think we (?) would want to cover:

https://github.com/openid/OpenID4VP/pull/155/files#diff-3118c9756a1d7b361bb53af8bd9d65666476a27cfeeced56c47a5dccc38eac55R1542

We need a separate WebDriver API that can vend credentials if we want something like this.

I generally agree that we need a WebDriver API, but that is fairly involved. Any chance there is a way that we can keep this test without going all the way to a WebDriver API?

Obviously, the test would be fine an internal Chrome unit test, but it's not something that helps us here with interop.

That's a reasonable compromise to me too: moving this specific test to a chrome-specific unit test as we improve the web platform tests infrastructure for the digital credential API.

This CL renames the digital-credential WPT files. The intention of this CL is to make #46642 easier to review as the renamed files are showing up as added+deleted in Github. BUG=5622820 Change-Id: Ia623539e5bc373e523d9ba27c930b4dab076be8e

This CL renames the digital-credential WPT files. The intention of this CL is to make #46642 easier to review as the renamed files are showing up as added+deleted in Github. BUG=5622820 Change-Id: Ia623539e5bc373e523d9ba27c930b4dab076be8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631578 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1315269}

pkotwicz

Added some review comments. Please rebase this CL with tip of tree.

digital-credentials/identity-get.tentative.https.html

digital-credentials/dc-types.ts

digital-credentials/support/helper.js

digital-credentials/identity-get.tentative.https.html

digital-credentials/identity-create.tentative.https.html

…estonly Automatic update from web-platform-tests Rename digital-credential WPT files This CL renames the digital-credential WPT files. The intention of this CL is to make web-platform-tests/wpt#46642 easier to review as the renamed files are showing up as added+deleted in Github. BUG=5622820 Change-Id: Ia623539e5bc373e523d9ba27c930b4dab076be8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631578 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1315269} -- wpt-commits: b98b066d2f5ac7966fb5e2fffedc5f56d8e590dd wpt-pr: 46758

…estonly Automatic update from web-platform-tests Rename digital-credential WPT files This CL renames the digital-credential WPT files. The intention of this CL is to make web-platform-tests/wpt#46642 easier to review as the renamed files are showing up as added+deleted in Github. BUG=5622820 Change-Id: Ia623539e5bc373e523d9ba27c930b4dab076be8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631578 Commit-Queue: Peter Kotwicz <pkotwiczchromium.org> Reviewed-by: Nicolás Peña <npmchromium.org> Cr-Commit-Position: refs/heads/main{#1315269} -- wpt-commits: b98b066d2f5ac7966fb5e2fffedc5f56d8e590dd wpt-pr: 46758 UltraBlame original commit: b2d5a8c4a9170a29373da4bf0ee937741373550f

…estonly Automatic update from web-platform-tests Rename digital-credential WPT files This CL renames the digital-credential WPT files. The intention of this CL is to make web-platform-tests/wpt#46642 easier to review as the renamed files are showing up as added+deleted in Github. BUG=5622820 Change-Id: Ia623539e5bc373e523d9ba27c930b4dab076be8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631578 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1315269} -- wpt-commits: b98b066d2f5ac7966fb5e2fffedc5f56d8e590dd wpt-pr: 46758

digital-credentials/support/helper.js

…estonly Automatic update from web-platform-tests Rename digital-credential WPT files This CL renames the digital-credential WPT files. The intention of this CL is to make web-platform-tests/wpt#46642 easier to review as the renamed files are showing up as added+deleted in Github. BUG=5622820 Change-Id: Ia623539e5bc373e523d9ba27c930b4dab076be8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5631578 Commit-Queue: Peter Kotwicz <[email protected]> Reviewed-by: Nicolás Peña <[email protected]> Cr-Commit-Position: refs/heads/main@{#1315269} -- wpt-commits: b98b066d2f5ac7966fb5e2fffedc5f56d8e590dd wpt-pr: 46758

digital-credentials/support/helper.js

digital-credentials/dc-types.ts

pkotwicz · 2024-07-17T17:29:36Z

Let me know when you are ready for another round of code review :)

marcoscaceres · 2024-07-17T22:54:20Z

@pkotwicz, I think these should be good to go now. Appreciate another review.

digital-credentials/identity-get.tentative.https.html

digital-credentials/identity-create.tentative.https.html

digital-credentials/get-user-activation.https.html

digital-credentials/support/helper.js

digital-credentials/support/iframe.html

digital-credentials/dc-types.ts

digital-credentials/identity-get.tentative.https.html

digital-credentials/support/iframe.html

pkotwicz · 2024-08-02T14:33:04Z

Wanted to apologize for the long delay in the code review. My github e-mail settings were screwed up

digital-credentials/dc-types.ts

pkotwicz · 2024-08-07T14:25:22Z

Let me know when you want another review on this CL

marcoscaceres · 2024-08-19T03:59:47Z

@pkotwicz, sorry for the slow churn on this... implementing in WebKit in parallel, so just coming back to this now.

Can you please take another look, also at #47662 ?

pkotwicz

Approval with nits

digital-credentials/identity-get.tentative.https.html

digital-credentials/support/helper.js

digital-credentials/identity-create.tentative.https.html

digital-credentials/support/helper.js

samuelgoto

LGTM++

wpt-pr-bot added digital-credentials status:needs-reviewers labels Jun 6, 2024

This was referenced Jun 6, 2024

Web Platform Tests: refactoring digitial-credentials.tentative.https.html WICG/digital-credentials#118

Closed

Add store(), create(), type, discovery internals WICG/digital-credentials#121

Merged

samuelgoto reviewed Jun 12, 2024

View reviewed changes

chromium-wpt-export-bot mentioned this pull request Jun 14, 2024

Rename digital-credential WPT files #46758

Merged

pkotwicz reviewed Jun 17, 2024

View reviewed changes

samuelgoto reviewed Jun 21, 2024

View reviewed changes

digital-credentials/support/helper.js Outdated Show resolved Hide resolved

marcoscaceres commented Jul 3, 2024

View reviewed changes

digital-credentials/support/helper.js Outdated Show resolved Hide resolved

wpt-pr-bot assigned marcoscaceres Jul 3, 2024

marcoscaceres commented Jul 4, 2024

View reviewed changes

digital-credentials/dc-types.ts Outdated Show resolved Hide resolved

marcoscaceres force-pushed the dc-create branch 2 times, most recently from f8b415a to 4efb1cb Compare July 4, 2024 03:04

marcoscaceres force-pushed the dc-create branch from 4efb1cb to 2c738a7 Compare July 17, 2024 06:18

wpt-pr-bot requested a review from tplooker July 17, 2024 06:18

marcoscaceres force-pushed the dc-create branch from 2c738a7 to 78e2d08 Compare July 17, 2024 08:04

pkotwicz suggested changes Aug 2, 2024

View reviewed changes

marcoscaceres commented Aug 7, 2024

View reviewed changes

digital-credentials/dc-types.ts Outdated Show resolved Hide resolved

marcoscaceres force-pushed the dc-create branch 2 times, most recently from d03f54d to 256ff1b Compare August 19, 2024 00:52

marcoscaceres mentioned this pull request Aug 19, 2024

Digital Credentials: digital-credentials-get Permissions Policy tests #47662

Merged

marcoscaceres added 8 commits August 19, 2024 13:27

Digital Credentials: test create and get

fd7361a

Fixes and user attention

7570d52

Additional get tests

22012a7

Review feedback plus other fixes

6b9514e

More fixes

1d88864

Moar fixes

8b9bfcf

review feedback

ac134b0

More review fixes

a5ae64b

marcoscaceres force-pushed the dc-create branch from 904a83b to a5ae64b Compare August 19, 2024 03:28

marcoscaceres added 3 commits August 19, 2024 17:14

Fixup

8294994

fixup

3938eb9

fixup focus

a30ab02

pkotwicz approved these changes Aug 19, 2024

View reviewed changes

marcoscaceres added 2 commits August 20, 2024 10:02

fix wrong focus

9cc3325

use string

bfd5525

marcoscaceres enabled auto-merge (squash) August 20, 2024 01:58

aprotyas approved these changes Aug 20, 2024

View reviewed changes

marcoscaceres merged commit f4e5691 into master Aug 20, 2024
19 checks passed

marcoscaceres deleted the dc-create branch August 20, 2024 02:13

moz-wptsync-bot added mozilla:gecko-blocked and removed mozilla:gecko-blocked labels Aug 20, 2024

samuelgoto reviewed Aug 20, 2024

View reviewed changes

Westbrook pushed a commit to Westbrook/wpt that referenced this pull request Aug 21, 2024

Digital Credentials: test create and get (web-platform-tests#46642)

e9e46d8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Digital Credentials: test create and get #46642

Digital Credentials: test create and get #46642

marcoscaceres commented Jun 6, 2024 •

edited

Loading

wpt-pr-bot commented Jun 6, 2024

samuelgoto Jun 12, 2024

marcoscaceres Jun 13, 2024 •

edited

Loading

samuelgoto Jun 21, 2024 •

edited

Loading

pkotwicz left a comment

pkotwicz commented Jul 17, 2024

marcoscaceres commented Jul 17, 2024

pkotwicz commented Aug 2, 2024

pkotwicz commented Aug 7, 2024

marcoscaceres commented Aug 19, 2024

pkotwicz left a comment

samuelgoto left a comment

Digital Credentials: test create and get #46642

Digital Credentials: test create and get #46642

Conversation

marcoscaceres commented Jun 6, 2024 • edited Loading

wpt-pr-bot commented Jun 6, 2024

samuelgoto Jun 12, 2024

Choose a reason for hiding this comment

marcoscaceres Jun 13, 2024 • edited Loading

Choose a reason for hiding this comment

samuelgoto Jun 21, 2024 • edited Loading

Choose a reason for hiding this comment

pkotwicz left a comment

Choose a reason for hiding this comment

pkotwicz commented Jul 17, 2024

marcoscaceres commented Jul 17, 2024

pkotwicz commented Aug 2, 2024

pkotwicz commented Aug 7, 2024

marcoscaceres commented Aug 19, 2024

pkotwicz left a comment

Choose a reason for hiding this comment

samuelgoto left a comment

Choose a reason for hiding this comment

marcoscaceres commented Jun 6, 2024 •

edited

Loading

marcoscaceres Jun 13, 2024 •

edited

Loading

samuelgoto Jun 21, 2024 •

edited

Loading