Use the new "dcb" and "dcz" content encodings of Compressed Dictionary #46436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5552563
branch
from
51126b9
to
6968838
Compare
The spec of Compression Dictionary Transport has been changed to use new `dcb` and `dcz` content encodings. httpwg/http-extensions#2784 To follow the spec change, this CL changes the Chromium implementation and tests as follows: - Use "dcb" content encoding name instead of "br-d". - Use "dcz" content encoding name instead of "zstd-d". - Remove the "Content-Dictionary" response header. - Check the magic number and the sha256 hash in the head of the Dictionary-Compressed streams using SharedDictionaryHeaderCheckerSourceStream. - Re-generate test files using the new content encodings. Bug: 1413922 Change-Id: I4f2f40c1f0c3666b4f0b54e34ad966ffccadd96b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5552563 Reviewed-by: Kenichi Ishibashi <[email protected]> Commit-Queue: Tsuyoshi Horo <[email protected]> Reviewed-by: Patrick Meenan <[email protected]> Cr-Commit-Position: refs/heads/main@{#1304826}
chromium-wpt-export-bot
force-pushed
the
chromium-export-cl-5552563
branch
from
6968838
to
f9e5dc4
Compare
wpt-pr-bot
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The spec of Compression Dictionary Transport has been changed to use
new
dcbanddczcontent encodings.httpwg/http-extensions#2784
To follow the spec change, this CL changes the Chromium implementation
and tests as follows:
Dictionary-Compressed streams using
SharedDictionaryHeaderCheckerSourceStream.
Bug: 1413922
Change-Id: I4f2f40c1f0c3666b4f0b54e34ad966ffccadd96b
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/5552563
Reviewed-by: Kenichi Ishibashi <[email protected]>
Commit-Queue: Tsuyoshi Horo <[email protected]>
Reviewed-by: Patrick Meenan <[email protected]>
Cr-Commit-Position: refs/heads/main@{#1304826}