[wptrunner] Report crash when WebDriver browser is not alive #45833
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This aligns with how the base class `TimedRunner` differentiates `CRASH` from other failure modes [0]. An `InvalidSessionIdException` after a browser death (e.g., [1]) is now coerced to `CRASH`, not the generic `INTERNAL-ERROR` for harness exceptions. Fixes web-platform-tests#39617 and https://crbug.com/41485463. [0]: https://github.com/web-platform-tests/wpt/blob/c338ceff/tools/wptrunner/wptrunner/executors/base.py#L216-L231 [1]: https://github.com/web-platform-tests/wpt/blob/c338ceff/tools/wptrunner/wptrunner/executors/base.py#L773
wpt-pr-bot
added
infra
wptrunner
WeizhongX
approved these changes
Apr 22, 2024
jonathan-j-lee
added a commit
to jonathan-j-lee/wpt
that referenced
this pull request
Jun 4, 2024
This is a follow-up improvement to web-platform-tests#45833. `Protocol.is_alive()` should handle a browser that's unable to even establish the low-level transport. `OSError` is a sufficiently broad base exception, which encompasses `socket.timeout`, `IOError`, and the `Connection*Error` family.
KyleJu
pushed a commit
that referenced
this pull request
Jun 5, 2024
* [wptrunner] Mark WebDriver protocol as not alive if `OSError` raised This is a follow-up improvement to #45833. `Protocol.is_alive()` should handle a browser that's unable to even establish the low-level transport. `OSError` is a sufficiently broad base exception, which encompasses `socket.timeout`, `IOError`, and the `Connection*Error` family. * Coerce all `WebDriverException`s to not alive * Update safari infrastructure expectation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This aligns with how the base class
TimedRunnerdifferentiatesCRASHfrom other failure modes.An
InvalidSessionIdExceptionafter a browser death when executing a testdriver action is now coerced toCRASH, not the genericINTERNAL-ERRORfor harness exceptions.Fixes #39617 and https://crbug.com/41485463.