Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the supported values of <link rel=preload as> #45200

Merged
merged 3 commits into from
Mar 19, 2024
Merged

Test the supported values of <link rel=preload as> #45200

merged 3 commits into from
Mar 19, 2024

Conversation

noamr
Copy link
Contributor

@noamr noamr commented Mar 19, 2024

The supported values are:
image, fetch, font, script, style, json, track

Unsupported values:

  • video, audio (streamed with range requests)
  • object, iframe, worklet, worker (not subresources)
  • any unknown value

See whatwg/html#10212

The supported values are:
image, fetch, font, script, style, json, track

Unsupported values:
- video, audio (streamed with range requests)
- object, iframe, worklet, worker (not subresources)
- any unknown value
preload/supported-as-values.html Outdated Show resolved Hide resolved
<script>
const params = new URLSearchParams(location.search);
const as = params.get("as");
const expected = +params.get("expected");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the "+" before "params" intentional?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's to make it a number, modified

preload/supported-as-values.html Show resolved Hide resolved
preload/supported-as-values.html Outdated Show resolved Hide resolved
Copy link
Contributor

@yoavweiss yoavweiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@noamr noamr enabled auto-merge (squash) March 19, 2024 16:21
@noamr noamr merged commit 5ac002e into master Mar 19, 2024
17 checks passed
@noamr noamr deleted the preload-as branch March 19, 2024 17:35
BruceDai pushed a commit to BruceDai/wpt that referenced this pull request Mar 25, 2024
…s#45200)

* Test the supported values of <link rel=preload as>

The supported values are:
image, fetch, font, script, style, json, track

Unsupported values:
- video, audio (streamed with range requests)
- object, iframe, worklet, worker (not subresources)
- any unknown value

* Remove spurious things

* Use step_timeout
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants